Conversation
* Fixes for latest MaxMind crate * New `fmt` fixes and markdown normalization * Remove hard coded timeouts Closes: PUSH-594
…to chore/PUSH-594_update-2512
Issue: PUSH-681
ncloudioj
reviewed
May 6, 2026
|
|
||
| fn handle(&mut self, msg: Connect, _ctx: &mut Context<Self>) -> Self::Result { | ||
| let session_id = self.rng.random::<u64>() as usize; | ||
| let session_id = self.rng.try_next_u64().unwrap() as usize; |
There was a problem hiding this comment.
Why switches to the fallible version? Is unwrap desirable inside of a handler?
Member
Author
There was a problem hiding this comment.
I was getting a clippy error off of calling random::<u64>, but apparently that's no longer a problem? Switching to RngExt which has the .random() call seems to fix that.
Member
Author
There was a problem hiding this comment.
Cool! I was also able to revert the TryRng in channelid.rs
…ices/channelserver into chore/PUSH-681_updates-2603
ncloudioj
approved these changes
May 6, 2026
kschelonka
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
chore: Update for 2026-Mar
Testing
How should reviewers test?
Issue(s)
Issue: PUSH-681