remove error in log message for PostgresUserReconciler.newSecretForCR#310
Open
xavi-clovr wants to merge 2 commits intomovetokube:masterfrom
Open
remove error in log message for PostgresUserReconciler.newSecretForCR#310xavi-clovr wants to merge 2 commits intomovetokube:masterfrom
xavi-clovr wants to merge 2 commits intomovetokube:masterfrom
Conversation
pcallewaert
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newSecretForCR for the PostgresUserReconciler is setting an error in case the port is not defined.
postgres-operator/internal/controller/postgresuser_controller.go
Line 325 in 615a675
In the end this is not an error, specially cause the code sets it to the default one by itself. However it's sending a log error with the whole stack trace of the
errbeing super verbose and being confusing.A recommendation would be to set it maximum as a warning or log and specially not sending the whole stack trace of the
err.