Add missing regression test for manual ip4table netifd classification#111
Draft
Copilot wants to merge 2 commits into
Draft
Add missing regression test for manual ip4table netifd classification#111Copilot wants to merge 2 commits into
ip4table netifd classification#111Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/mossdef-org/pbr/sessions/6661e7b3-71cc-419f-9aa2-b905191faad9 Co-authored-by: stangri <4768176+stangri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment suggestion
Add missing regression test for manual May 20, 2026
ip4table netifd classification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review pointed out that the PR description claimed a regression test for the netifd/manual-
ip4tableclassification bug, but no such test was present. This change adds that missing coverage without changing production code.Regression coverage
tests/05_interfaces/04_netifd_mark_chain.ip4tableset in UCI but is not pbr-managed viaenv.netifd_mark.What the test asserts
action == 'create').ifacesTriggers.gotothe generatedpbr_mark_<mark>chain.Scope