[WIP] [WIP] Address feedback on service rework from PR #19 review comments#20
Merged
morgangraphics merged 1 commit intofeature/flask-to-fastapi-upgradefrom Mar 25, 2026
Merged
Conversation
morgangraphics
merged commit 2ce6700
into
feature/flask-to-fastapi-upgrade
1 of 2 checks passed
Copilot stopped work on behalf of
morgangraphics due to an error
March 25, 2026 01:16
morgangraphics
added a commit
that referenced
this pull request
Mar 25, 2026
* Reworked entire service to FastAPI, uv, dependency updates, Makefile, Dockerfile, tests, the entire works * newline * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * issues with unused imports, documentation, codacy false positives * Update service/models.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update service/routes/marvel.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update service/routes/dc.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update service/routes/marvel.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update service/routes/dc.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Initial plan (#20) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * [WIP] [WIP] Address feedback on service rework implementation (#21) * Initial plan * Fix POST description in dc.py to use 'characters' instead of 'character' Co-authored-by: morgangraphics <607594+morgangraphics@users.noreply.github.com> Agent-Logs-Url: https://github.com/morgangraphics/simple-superhero-service-python/sessions/adfde50c-baa8-4475-92be-57a754fa9768 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: morgangraphics <607594+morgangraphics@users.noreply.github.com> * Codacy linting issues * Codacy linting updates * Codacy issues --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: morgangraphics <607594+morgangraphics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #19. I've created this new PR, which merges into #19, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #19
Triggering review: #19 (comment)
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.