-
Notifications
You must be signed in to change notification settings - Fork 0
feat(deploy): add new NVIDIA accelerators and update NFD rules #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,15 @@ Each accelerator is identified by labels prefixed with `moai.moreh.io`. Users ca | |
| | `moai.moreh.io/accelerator.vendor: amd`<br/>`moai.moreh.io/accelerator.model: mi250` | Half of AMD Instinct MI250 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: amd`<br/>`moai.moreh.io/accelerator.model: mi210` | AMD Instinct MI210 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: amd`<br/>`moai.moreh.io/accelerator.model: mi100` | AMD Instinct MI100 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h100` | NVIDIA H100 SXM GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: b300` | NVIDIA B300 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: b200` | NVIDIA B200 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h200-sxm` | NVIDIA H200 SXM GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h100-pcie` | NVIDIA H100 PCIe GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h100-80gb-hbm3` | NVIDIA H100 80GB HBM3 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h100-sxm` | NVIDIA H100 SXM GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h20-3e` | NVIDIA H20-3e GPU | | ||
|
Comment on lines
29
to
+31
|
||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h800` | NVIDIA H800 GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: h800-pcie` | NVIDIA H800 PCIe GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: a100-80gb-sxm` | NVIDIA A100 80GB SXM GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: a100-80gb-pcie` | NVIDIA A100 80GB PCIe GPU | | ||
| | `moai.moreh.io/accelerator.vendor: nvidia`<br/>`moai.moreh.io/accelerator.model: a100-40gb-pcie` | NVIDIA A100 40GB PCIe GPU | | ||
| | `moai.moreh.io/accelerator.vendor: tenstorrent`<br/>`moai.moreh.io/accelerator.model: blackhole` | Tenstorrent Blackhole NPU | | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By removing the previous
accelerator-nvidia-h100rule (which matched PCI device ID2339) and not adding2339to any other rule, nodes reporting10de:2339will no longer get anymoai.moreh.io/accelerator.*labels. If2339is still a valid H100/Hopper device ID in your target environments, consider mapping it to the correct model (e.g., add it toh100-sxmor create a dedicated rule) and document the source for the ID choice.