Skip to content

feat: add metaplex skill — Solana NFTs, tokens, compressed NFTs, candy machines, token launches, agent identity#42

Closed
tonyagents wants to merge 4 commits into
moonpay:mainfrom
tonyagents:add-metaplex-skills
Closed

feat: add metaplex skill — Solana NFTs, tokens, compressed NFTs, candy machines, token launches, agent identity#42
tonyagents wants to merge 4 commits into
moonpay:mainfrom
tonyagents:add-metaplex-skills

Conversation

@tonyagents
Copy link
Copy Markdown
Contributor

Skill name

metaplex

Description

Metaplex development on Solana — NFTs, tokens, compressed NFTs, candy machines, token launches, and autonomous agent identity via the mplx CLI and Umi SDK. Sourced from the official metaplex-foundation/skill repository.

Primary chain

Solana (mainnet + devnet)

Primary token

SOL (gas), SPL tokens, NFTs

Checklist

  • Frontmatter (name, description) present
  • Skill registered in .claude-plugin/marketplace.json under metaplex-skills plugin at ./skills/metaplex
  • Naming convention: metaplex/ (partner=metaplex-foundation, single skill)
  • mplx CLI verified: published at @metaplex-foundation/cli on npm
  • All 20 reference files included: CLI guides (11) + SDK guides (7) + concepts + metadata-json
  • No fabricated commands — all sourced directly from the official Metaplex skill repo
  • Signed commit (verified)

Programs covered

Program CLI Umi SDK Kit SDK
Core (next-gen NFTs)
Token Metadata (NFTs, pNFTs, fungibles)
Bubblegum (compressed NFTs)
Candy Machine (NFT drops)
Genesis (token launches)
Agent Registry (on-chain identity, delegation)

Installation

npm install -g @metaplex-foundation/cli
mplx --help

MoonPay Integration

Agents use mplx CLI to create and manage Solana NFTs/tokens, then use MoonPay to fund the wallet (mp buy --token sol) before signing transactions.

…nes, token launches, agent identity on Solana

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tonyagents tonyagents requested a review from a team as a code owner April 2, 2026 04:16
Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grade: B — Close to mergeable but has a few issues that need fixing before merge.

Verified

  • @metaplex-foundation/cli — real npm package, v0.2.0, binary is mplx. Confirmed.
  • All npm packages verified: mpl-core, mpl-bubblegum, mpl-token-metadata, mpl-agent-registry, mpl-core-candy-machine, genesis, umi, umi-bundle-defaults, digital-asset-standard-api, mpl-token-metadata-kit. All real.
  • marketplace.json — correctly placed in a separate metaplex-skills plugin block, not inside moonpay-skills.
  • Clean diff — only the skill directory and marketplace.json touched.
  • No security issues — no raw private key handling.

Issues to Fix

1. Naming convention violation (blocking)

Skill is at skills/metaplex/ — must follow skills/{partner}-{name}/ convention. CONTRIBUTING.md explicitly calls out bare names: "Bare skill names — skills/dune/ instead of skills/dune-analytics/. Always use {partner}-{name}." Rename to something like skills/metaplex-development/ or skills/metaplex-solana-nfts/.

2. Missing tags in frontmatter (blocking)

Rubric requires name, description, and tags in frontmatter. Currently only name and description are present. Add a tags array (e.g., tags: [solana, nft, token-metadata, compressed-nfts, candy-machine, token-launch, agent-identity]).

3. No Prerequisites section in main SKILL.md (blocking)

The rubric requires a Prerequisites section listing setup requirements (CLI installs, auth, funded wallets). Setup info exists in references/cli-initial-setup.md but is missing from the main SKILL.md. Add a Prerequisites section, at minimum:

## Prerequisites
- Node.js installed
- Metaplex CLI installed: `npm install -g @metaplex-foundation/cli`
- CLI configured (RPC, keypair, funded wallet) — see `./references/cli-initial-setup.md`

4. TypeScript SDK code in reference files (non-blocking, but worth discussing)

The repo convention is "No code: Skills are instructional guides. No Python scripts, no TypeScript SDK code." Seven SDK reference files contain substantial TypeScript — hundreds of lines. The SKILL.md itself correctly prioritizes CLI over SDK, and all CLI commands are verified and real. The SDK code is technically a rubric violation, but it's structured as reference material rather than executable scripts, and the CLI-first approach is clear. I'd recommend either (a) removing the SDK reference files entirely and pointing to Metaplex docs for SDK usage, or (b) discussing with the maintainers whether reference-style SDK documentation is acceptable. Not blocking on this since it's a gray area.

5. No cross-references to related skills (minor)

The skill doesn't reference any existing repo skills (e.g., moonpay-buy-crypto for funding wallets with SOL, moonpay-check-wallet for balance checks). Consider adding a Related Skills section.

Summary

The content quality is excellent — comprehensive, well-organized, all commands and packages verified real. The three blocking items (naming, tags, prerequisites) are straightforward fixes. Once addressed, this is ready to merge.

Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A- — One small decision needed on SDK reference files

Great progress — all three prior blockers addressed:

  • Renamed to skills/metaplex-development/ (naming convention) ✓
  • Tags added to frontmatter ✓
  • Prerequisites section added ✓

@metaplex-foundation/cli v0.2.0+ verified, reference docs well-organized, marketplace.json placed in its own metaplex-skills plugin block.

One ask

The 7 SDK reference files (references/sdk-*.md) contain substantial TypeScript code. The rubric says "No Python scripts, no TypeScript SDK code. All execution happens through CLIs."

Either:

  1. Remove the SDK reference files (point to official Metaplex docs for SDK users), OR
  2. Add a clear note at the top of each SDK reference: e.g., "This file is advisory only. Agents should use the mplx CLI commands documented in SKILL.md. SDK snippets are included for human developers integrating Metaplex directly."

Option 2 is faster. CLI-first is clearly maintained in SKILL.md, so this is a clarity fix, not a rewrite.

Small nice-to-have (not blocking): cross-reference moonpay-buy-crypto / moonpay-check-wallet for wallet funding.

Resolve the SDK note and this is A+.

Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ — Ready to merge

Advisory headers added to all 7 SDK reference files (sdk-umi.md, sdk-agent.md, sdk-bubblegum.md, sdk-core.md, sdk-genesis.md, sdk-token-metadata.md) directing agents to the mplx CLI in SKILL.md. Satisfies the no-code rule while preserving human-developer docs.

Verified: @metaplex-foundation/cli v0.2.0+, naming metaplex-development, own metaplex-skills plugin block, prerequisites + tags complete.

Merging.

@kevarifin14
Copy link
Copy Markdown
Contributor

Superseded by #60 (cherry-pick onto current main, marketplace.json conflict resolved). Closing. Credit preserved via Co-Authored-By. Thanks @tonyagents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants