Skip to content

feat: add perp skills — multi-exchange perpetual futures execution#39

Closed
tonyagents wants to merge 4 commits into
moonpay:mainfrom
tonyagents:add-perp-skills
Closed

feat: add perp skills — multi-exchange perpetual futures execution#39
tonyagents wants to merge 4 commits into
moonpay:mainfrom
tonyagents:add-perp-skills

Conversation

@tonyagents
Copy link
Copy Markdown
Contributor

Skills added (3)

Perpetual futures execution across Hyperliquid, Pacifica, Lighter, and Aster via perp-cli MCP tools.

  • perp-trade — execute market/limit orders with pre-trade checklist (margin, liquidation, slippage), and run automated TWAP/DCA/grid/trailing-stop bots
  • perp-arb — funding rate arbitrage scout: scan spreads across all exchanges, run net P&L math (funding earned - fees - slippage), risk checks, ranked output
  • perp-portfolio — aggregate all open positions, balances, uPnL, and risk flags (high margin, near liquidation, funding burn) across every connected exchange

Checklist

  • Frontmatter (name, description, tags) present on all 3 skills
  • Skill files present in skills/ (committed in c89b1ae)
  • Registered in .claude-plugin/marketplace.json under separate perp-skills plugin block
  • Naming convention: perp-{name}/
  • No TypeScript/Python code — all instruction-based skills using perp-cli MCP tools
  • No phantom cross-references

tonyagents and others added 2 commits April 1, 2026 11:55
- dawn, dawn-auth, dawn-sdk-tools, dawn-strategy: full workflow skills for the @dawnai/cli trading strategy platform (MoonPay-built, Polymarket execution)
- perp-arb: funding rate arbitrage scout across Hyperliquid, Pacifica, Lighter, Aster
- perp-portfolio: multi-exchange perpetual futures portfolio aggregator
- perp-trade: perp order execution with pre-trade checks, TWAP/DCA/grid/trailing-stop bots

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds perp-skills plugin block (perp-trade, perp-arb, perp-portfolio).
Skill files were added in c89b1ae.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grade: C (Needs work)

Verified

  • perp-cli is a real npm package (v0.9.8, published 2 days ago) with MCP server support (perp-mcp binary). Covers Hyperliquid, Pacifica, Lighter, Aster. Legitimate tool.
  • @dawnai/cli is a real npm package (v1.2.5). Dawn skills reference real commands.
  • marketplace.json: perp-skills correctly placed in a separate plugin block, not inside moonpay-skills.
  • Naming convention: perp-trade, perp-arb, perp-portfolio follow {partner}-{name} convention.
  • Frontmatter: All 3 perp skills have name, description, tags. Descriptions are trigger-specific.

Issues

1. Unrelated changes — 4 dawn skills bundled into a perp PR (Clean diff violation)

The PR description says "Skills added (3)" for perpetual futures, but the diff adds 7 new skill files: skills/dawn/, skills/dawn-auth/, skills/dawn-sdk-tools/, skills/dawn-strategy/ in addition to the 3 perp skills. The dawn skills are completely unrelated to perpetual futures trading. These should be submitted in a separate PR.

2. Dawn skills not registered in marketplace.json

The 4 dawn skill directories are added as files but have no corresponding plugin block in marketplace.json. They are orphaned — no agent can discover them. If they're intended to be included, they need a dawn-skills plugin block. But they should be in their own PR regardless.

3. Missing Prerequisites section on all 3 perp skills

None of the perp skills include a Prerequisites section. Per the template and rubric, this is required. At minimum:

  • npm install -g perp-cli
  • Exchange API key configuration (how does an agent connect to Hyperliquid/Pacifica/Lighter/Aster?)
  • Wallet/margin account setup

4. No concrete CLI commands — skills reference vague "MCP tools"

The perp skills say things like:

  • "Use perp-cli trade MCP tools" (perp-trade)
  • "Use perp-cli account and portfolio MCP tools" (perp-portfolio)
  • "Use perp-cli's trade MCP tools to place both legs" (perp-arb)

But they never specify the actual MCP tool names, parameters, or invocation syntax. An agent reading these skills would not know what commands to run. The perp-cli package exposes a perp-mcp binary — the skills should document the actual MCP tool names (e.g., perp trade market, perp arb scan, etc.) or at minimum reference perp --help so the agent can discover them.

5. No cross-references between the 3 perp skills

perp-trade, perp-arb, and perp-portfolio are related but don't reference each other. For example, perp-trade should reference perp-portfolio for checking positions, and perp-arb should reference perp-trade for execution.

What to fix

  1. Remove the 4 dawn skills from this PR and submit them separately with their own marketplace.json plugin block.
  2. Add a Prerequisites section to each perp skill with install command (npm install -g perp-cli), exchange configuration, and wallet setup.
  3. Replace vague "MCP tools" references with actual commands. Run perp --help and perp-mcp to discover the real tool names and document them.
  4. Add cross-references between the 3 perp skills in a Related Skills section.

…add Prerequisites and cross-references

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B — One small fix from A+

All 5 items from my 2026-04-01 review are addressed:

  • Dawn skills split out (now separate PR #38) ✓
  • Prerequisites sections added across all 3 skills ✓
  • Real CLI commands documented (perp trade market, perp arb scan, perp portfolio, etc.) ✓
  • Cross-references between perp-trade/perp-arb/perp-portfolio added ✓
  • marketplace.json placement correct (own perp-skills plugin block) ✓

Verified: perp-cli v0.11.0 is real on npm, exposes perp, perp-mcp, perp-guardrail binaries; supported exchanges (Hyperliquid, Pacifica, Lighter, Aster) match docs.

One ask before A+

Add a Security/Risk section to perp-trade covering:

  • Liquidation risk warning — leverage > 1x can result in 100% loss; recommend stop-loss via perp trade tpsl before entering leveraged positions
  • Private key storage — where perp setup stores the key, and any rotation/cleanup guidance

Perpetual futures are high-risk by nature. The rubric requires security warnings for private-key handling, and leverage warnings are the industry norm.

Add this and it's A+.

Copy link
Copy Markdown
Contributor

@kevarifin14 kevarifin14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ — Ready to merge

Security & Risk section added to perp-trade (commit 1244bf2) — leverage warning, stop-loss requirement, liquidation threshold guidance, private key storage + rotation. That was my single ask.

Verified: perp-cli v0.11.0 + Hyperliquid/Pacifica/Lighter/Aster; all 3 skills have prerequisites, cross-refs wired (perp-tradeperp-portfolioperp-arb); own perp-skills plugin block.

Merging.

@kevarifin14
Copy link
Copy Markdown
Contributor

Superseded by #58 (cherry-pick onto current main, marketplace.json conflict resolved). Closing. Credit preserved via Co-Authored-By. Thanks @tonyagents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants