Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
aarchmrs-gen/src/generation.rs (1)
31-61:⚠️ Potential issue | 🟠 MajorUpdate the golden output tests for the new
FIELD_*emissions (CI is failing).Lines 31–61 now emit extra constants, but
generation::tests::test_addstill asserts the old output and is failing in CI (failure reported at Line 233). Please update the expected rendered string to include the new#[cfg(feature = "meta_field")]constants.✅ Expected-string update sketch (test)
"#[cfg(feature = \"meta\")]\n", "pub const NAME: &str = \"ADD_64_addsub_shift\";\n", + "#[cfg(feature = \"meta_field\")]\n", + "#[allow(nonstandard_style)]\n", + "pub const FIELD_Rd_OFFSET: u32 = 0u32;\n", + "#[cfg(feature = \"meta_field\")]\n", + "#[allow(nonstandard_style)]\n", + "pub const FIELD_Rd_WIDTH: u32 = 5u32;\n", + // ...remaining FIELD_* constants... "#[inline]\n",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@aarchmrs-gen/src/generation.rs` around lines 31 - 61, The golden-output test generation::tests::test_add is failing because the new arg_metas emission adds per-field constants (FIELD_<NAME>_OFFSET and FIELD_<NAME>_WIDTH) guarded by #[cfg(feature = "meta_field")]; update the expected rendered string in that test to include those new lines (#[cfg(feature = "meta_field")] #[allow(nonstandard_style)] pub const FIELD_<NAME>_OFFSET: u32 = <offset>; and similar for FIELD_<NAME>_WIDTH) alongside the existing #[cfg(feature = "meta")] OPCODE_MASK/OPCODE/SHOULD_BE_MASK/NAME constants so the test matches the output produced by the arg_metas mapping.
🧹 Nitpick comments (1)
aarchmrs-instructions/Cargo.toml (1)
18-18: Consider makingmeta_fieldimplymeta.Line 18 currently defines
meta_fieldindependently. If the intent is for field metadata to extend the existing metadata surface, wiring it asmeta_field = ["meta"]avoids partial metadata output when onlymeta_fieldis enabled.♻️ Suggested feature composition
[features] default = ["A64"] meta = [] -meta_field = [] +meta_field = ["meta"] A64 = [] A32 = [] T32 = []🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@aarchmrs-instructions/Cargo.toml` at line 18, The current Cargo.toml sets meta_field = [] which leaves field-level metadata independent; update the configuration so enabling meta_field also enables meta by setting meta_field = ["meta"] (i.e., wire the meta_field feature to include the meta feature) so field metadata extends the existing metadata surface and avoids partial output when only meta_field is enabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@aarchmrs-gen/src/downloads.rs`:
- Line 23: Remove the incidental dbg! invocation used when building the archive
path: replace the dbg!(cache_dir.join(AARCHMRS_2025_12_FILE)) usage so that
archive_file is assigned the plain path (cache_dir.join(AARCHMRS_2025_12_FILE))
without printing debug output; change the expression where archive_file is
declared (the let archive_file = ...) to eliminate dbg! while keeping the same
join with AARCHMRS_2025_12_FILE.
---
Outside diff comments:
In `@aarchmrs-gen/src/generation.rs`:
- Around line 31-61: The golden-output test generation::tests::test_add is
failing because the new arg_metas emission adds per-field constants
(FIELD_<NAME>_OFFSET and FIELD_<NAME>_WIDTH) guarded by #[cfg(feature =
"meta_field")]; update the expected rendered string in that test to include
those new lines (#[cfg(feature = "meta_field")] #[allow(nonstandard_style)] pub
const FIELD_<NAME>_OFFSET: u32 = <offset>; and similar for FIELD_<NAME>_WIDTH)
alongside the existing #[cfg(feature = "meta")]
OPCODE_MASK/OPCODE/SHOULD_BE_MASK/NAME constants so the test matches the output
produced by the arg_metas mapping.
---
Nitpick comments:
In `@aarchmrs-instructions/Cargo.toml`:
- Line 18: The current Cargo.toml sets meta_field = [] which leaves field-level
metadata independent; update the configuration so enabling meta_field also
enables meta by setting meta_field = ["meta"] (i.e., wire the meta_field feature
to include the meta feature) so field metadata extends the existing metadata
surface and avoids partial output when only meta_field is enabled.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (296)
aarchmrs-instructions/src/A32/brblk/b_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/brblk/ldstexcept.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/brblk/ldstm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/floatdpmac.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/fpcsel.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/fpcvtrnd.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/fpextins.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/fpminmaxnm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/simd3reg_sameext.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/advsimdext/simd_dotprod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/fpdp/fpdp2reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/fpdp/fpdp3reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/fpdp/fpimm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/svcall/svc.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sys_mov32/movcpgp32.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sys_mov32/movfpgp16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sys_mov32/movfpgp32.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sys_mov32/movfpsr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sys_mov32/movsimdgp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sysldst_mov64/ldstcp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sysldst_mov64/ldstsimdfp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sysldst_mov64/movcpgp64.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/cops_as/sysldst_mov64/movsimdfpgp64.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpimm/intdp1reg_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpimm/intdp2reg_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpimm/log2reg_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpimm/movsr_hint_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpimm/movw.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/blx_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/bx_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/bxj_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/clz.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/crc32.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/eret.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/except.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/intsat.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpmisc/movsr_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregis/intdp2reg_immsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregis/intdp3reg_immsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregis/logic3reg_immsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregrs/intdp2reg_regsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregrs/intdp3reg_regsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/dpregrs/logic3reg_regsh.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/mul_half.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/mul_word.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/sync/ldst_excl.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/xldst/ldstximm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/dp/xldst/ldstxreg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/ldstimm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/ldstreg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/bfi.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/bfx.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/extend.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/pack.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/parallel.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/reverse.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/sat16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/sat32.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/selbytes.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/smul_div.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/udf.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/media/usad.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_12reg/simd1reg_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_12reg/simd2reg_shift.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd2reg_dup.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd2reg_misc.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd2reg_scalar.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd3reg_diff.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd3reg_ext.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/a_simd_mulreg/simd3reg_tbl.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimddp/simd3reg_same.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimdls/ldstv_ms.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimdls/ldstv_ssone.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/advsimdls/ldv_ssall.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/uncondhints/barriers.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/uncondhints/preload_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/uncondhints/preload_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/uncondmisc/cps.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A32/uncond_as/uncondmisc/setpan.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/barriers.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/branch_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/branch_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/compbranch.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/compbranch_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/compbranch_regs.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/compbranch_regs2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/condbranch.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/exception.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/hints.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/miscbranch.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/pstate.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/syspairinstrs.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/systeminstrs.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/systeminstrswithreg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/systemmove.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/systemmovepr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/tchange_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/tchange_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/control/testbranch.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/addsub_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/addsub_immtags.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/bitfield.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/dp_1src_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/extract.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/log_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/minmax_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/movewide.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpimm/pcreladdr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/addsub_carry.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/addsub_ext.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/addsub_pt.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/addsub_shift.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/condcmp_imm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/condcmp_reg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/condsel.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/dp_1src.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/dp_2src.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/dp_3src.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/log_shift.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/rmif.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/dpreg/setf.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/asisdlse.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/asisdlsep.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/asisdlso.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/asisdlsop.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/comswap.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/comswap_unpriv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/comswappr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/comswappr_unpriv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldapstl_simd.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldapstl_unscaled.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldapstl_writeback.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldiappstilp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_gcs.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_immpost.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_immpre.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_pac.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_pos.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_regoff.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_unpriv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldst_unscaled.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstexclp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstexclr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstexclr_unpriv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstnapair_offs.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstord.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstpair_off.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstpair_post.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldstpair_pre.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/ldsttags.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/loadlit.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/memcms.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/memop.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/memop_128.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/memop_unpriv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/memset_go.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/rcwcomswap.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/ldst/rcwcomswappr.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/reserved/perm_undef.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdall.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimddiff.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdelem.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdext.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdimm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdins.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdmisc.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdmiscfp16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdperm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdsame.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdsame2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdsamefp16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdshf.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asimdtbl.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisddiff.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdelem.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdmisc.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdmiscfp16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdone.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdpair.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdsame.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdsame2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdsamefp16.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/asisdshf.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/crypto3_imm2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/crypto3_imm6.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/crypto4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/cryptoaes.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/cryptosha2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/cryptosha3.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/cryptosha512_2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/cryptosha512_3.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/float2fix.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/float2int.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatccmp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatcmp.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatdp1.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatdp2.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatdp3.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatimm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/simd_dp/floatsel.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_64bit_prod4/mortlach_f64f64_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_64bit_prod4/mortlach_i16i64_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_misc_prod/mortlach_b16b16_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_misc_prod/mortlach_bini32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_misc_prod/mortlach_f16f16_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_misc_prod/mortlach_f8f16_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_b16b16_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_b16f32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_f16f16_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_f16f32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_f32f32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_f8f16_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_f8f32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_i16i32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_prod4/mortlach_i8i32_prod4.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_b16b16_1in2ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_b16f32_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_f16f16_1in2ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_f16f32_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_f32f32_1in2ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_f8f16_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_f8f32_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_i16i32_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach2_ss_prod/mortlach_i8i32_2in4ss_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_fp_prod/mortlach_b16f32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_fp_prod/mortlach_f16f32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_fp_prod/mortlach_f32f32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_fp_prod/mortlach_f8f32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_int_prod/mortlach_i16i32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_32bit_int_prod/mortlach_i8i32_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_64bit_prod/mortlach_f64f64_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_64bit_prod/mortlach_i16i64_prod.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_extract_pred.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_extract_zero.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi2_extract_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi2_extract_zero.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi2_za_extract_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi2_za_extract_zero.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi4_extract_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi4_extract_zero.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi4_za_extract_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ext/mortlach_multi4_za_extract_zero.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_hvadd/mortlach_addhv.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ins/mortlach_insert_pred.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ins/mortlach_multi2_insert_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ins/mortlach_multi2_za_insert_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ins/mortlach_multi4_insert_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_ins/mortlach_multi4_za_insert_ctg.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_contig_load.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_contig_qload.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_contig_qstore.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_contig_store.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_ctxt_ldst.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mem/mortlach_zt_ldst.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mov_zt/mortlach_extract_zt.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mov_zt/mortlach_insert_zt.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_mov_zt/mortlach_move_to_zt.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi1_zz_za_fma_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi1_zz_za_mla_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi1_zz_za_mla_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_z_za_2way_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_z_za_4way_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_z_za_fpdot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_z_za_mixed_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_f16_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_float_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_fma_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_fp8_fma_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_int_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_mla_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1a/mortlach_multi2_zz_za_mla_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi1_zz_za_fp8_fma_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi1_zz_za_fp8_fma_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_z_za_2way_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_z_za_4way_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_z_za_fpdot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_z_za_mixed_dot_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_f16_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_float_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_fma_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_fp8_fma_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_int_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_mla_long_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_1b/mortlach_multi4_zz_za_mla_long_sm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_2way_dot_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_4way_dot_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_f16_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_float_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_fpdot_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_int_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_z_za_mixed_dot_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_zz_za_f16_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_zz_za_float_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_zz_za_fma_long_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_zz_za_fp8_fma_long_long_mm.rsis excluded by!aarchmrs-instructions/src/**aarchmrs-instructions/src/A64/sme/mortlach_multi_array_2a/mortlach_multi2_zz_za_fp8_fma_long_mm.rsis excluded by!aarchmrs-instructions/src/**
📒 Files selected for processing (4)
aarchmrs-gen/src/downloads.rsaarchmrs-gen/src/generation.rsaarchmrs-instructions/CHANGELOG.mdaarchmrs-instructions/Cargo.toml
Summary by CodeRabbit
New Features
Chores