This repository was archived by the owner on Dec 15, 2020. It is now read-only.
Modify for new mlpd format.#5
Open
omanuke wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified heap-shot reader to work with new mlpd format which Xamarin.Profiler 0.34 generates.
I asked about this format chang at mlpd file format has changed? and RodorigoMoya told me new format is written in comment of proflog.c.
So I saw it and modified.
Modified heapshot.reader can read new mlpd format without error,but I'm not sure this modification is enough.
For example, comment said TYPE_SAMPLE_HIT have mbt_count and method,but it seems that there isn't in genereated mlpd file.
And this modified heapshot.reader may not work for old format.