fix(account): filter buttons not working (@fehmer)#7505
Merged
Conversation
fehmer
force-pushed
the
feature/fix-resultfiter-chart
branch
from
9c1577a to
42cbc62
Compare
fehmer
changed the title
fehmer
changed the title
Leonabcd123
reviewed
Feb 19, 2026
| toggle(group, filter); | ||
| // filters[group][filter] = !filters[group][filter]; | ||
| } else { | ||
| const group = (e.target as HTMLElement).parentElement?.getAttribute( |
Contributor
There was a problem hiding this comment.
Can we use the already existing variable childTarget instead of e.target?
IliyaZinoviev
pushed a commit
to IliyaZinoviev/monkeytype
that referenced
this pull request
Apr 24, 2026
## unable to select filter presets, chart not updating reproduce: - create two presets e.g. `all` and `last three month` - switch between presets The current preset doesnt get highlighted and the chart doesnt get updated. ## advanced filters - clear filters not working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unable to select filter presets, chart not updating
reproduce:
allandlast three monthThe current preset doesnt get highlighted and the chart doesnt get updated.
advanced filters