Deployments: Refactors Docker setup for clarity#97
Merged
Conversation
Moves Dockerfiles to more specific locations. Updates docker-compose to utilize build contexts instead of pre-built images. This change improves project organization.
There was a problem hiding this comment.
Pull Request Overview
Refactors the Docker setup for the Eclipse web service by simplifying paths, centralizing build configurations in Docker Compose, adding useful ignore patterns, and removing a redundant build script.
- Simplified COPY commands in the Eclipse Dockerfile to match the new build context
- Added
.dockerignoreentries fornode_modules,dist, and.vscode - Updated
docker-compose.yamlto build images from context instead of pulling prebuilt images - Removed the obsolete
build.shdeployment script
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/eclipse/deployments/eclipse.Dockerfile | Updated COPY paths to assume the build context is web/eclipse |
| web/eclipse/.dockerignore | Ignoring common build artifacts and editor configs |
| deployments/demo/docker-compose.yaml | Switched from image: to build: for services |
| deployments/build.sh | Deleted legacy build script in favor of Docker Compose builds |
Comments suppressed due to low confidence (1)
deployments/build.sh:1
- Since this script was removed, update any documentation (e.g., README) or CI configurations that reference
deployments/build.shto prevent broken links or commands.
#!/bin/bash
ILL1A
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96.