Skip to content

ci: exclude spec files from copilot review#4919

Merged
tadjik1 merged 2 commits intomainfrom
copilot-exclude-spec-files
Apr 14, 2026
Merged

ci: exclude spec files from copilot review#4919
tadjik1 merged 2 commits intomainfrom
copilot-exclude-spec-files

Conversation

@tadjik1
Copy link
Copy Markdown
Member

@tadjik1 tadjik1 commented Apr 13, 2026

Description

Summary of Changes

Provide custom instruction for Copilot to ignore spec files.
As per official documentation: https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#creating-path-specific-custom-instructions

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review April 13, 2026 11:18
@tadjik1 tadjik1 requested a review from a team as a code owner April 13, 2026 11:18
Copilot AI review requested due to automatic review settings April 13, 2026 11:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds repository-level, path-specific GitHub Copilot instructions to avoid suggesting changes to upstream-copied spec test files under test/spec/.

Changes:

  • Introduces a new .github/instructions/*.instructions.md file with applyTo targeting test/spec/**.
  • Instructs Copilot to not suggest modifications to those spec test files to preserve upstream parity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dariakp dariakp self-assigned this Apr 13, 2026
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 13, 2026
Copy link
Copy Markdown

Copilot AI commented Apr 13, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fake
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-experimental-strip-types /home/REDACTED/work/node-mongodb-native/node-mongodb-native/node_modules/mocha/lib/cli/cli.js test/unit --no-config --no-package --require source-map-support/register --require ts-node/register --require test/tools/REDACTED/throw_rejections.cjs --require test/tools/REDACTED/chai_addons.ts --require test/tools/REDACTED/ee_checker.ts --extension js --extension ts (dns block)
  • localhost.a.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-experimental-strip-types /home/REDACTED/work/node-mongodb-native/node-mongodb-native/node_modules/mocha/lib/cli/cli.js test/unit --no-config --no-package --require source-map-support/register --require ts-node/register --require test/tools/REDACTED/throw_rejections.cjs --require test/tools/REDACTED/chai_addons.ts --require test/tools/REDACTED/ee_checker.ts --extension js --extension ts (dns block)
  • non-existent
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-experimental-strip-types /home/REDACTED/work/node-mongodb-native/node-mongodb-native/node_modules/mocha/lib/cli/cli.js test/unit --no-config --no-package --require source-map-support/register --require ts-node/register --require test/tools/REDACTED/throw_rejections.cjs --require test/tools/REDACTED/chai_addons.ts --require test/tools/REDACTED/ee_checker.ts --extension js --extension ts (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from dariakp April 13, 2026 21:02
@tadjik1 tadjik1 merged commit 01eb278 into main Apr 14, 2026
7 checks passed
@tadjik1 tadjik1 deleted the copilot-exclude-spec-files branch April 14, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants