fix(mcp): add origin validation to useRenderData hook#3500
Open
RinZ27 wants to merge 1 commit intomongodb:mainfrom
Open
fix(mcp): add origin validation to useRenderData hook#3500RinZ27 wants to merge 1 commit intomongodb:mainfrom
RinZ27 wants to merge 1 commit intomongodb:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7e1319c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
I've implemented origin validation in the
useRenderDatahook to enhance security for iframe-based communication in the MCP integration. Previously, the hook's message handler accepted data from any source origin without verification. This update introduces an optionalallowedOriginsconfiguration, allowing developers to restrict data updates to trusted origins only.🎟 Jira ticket: N/A (Security enhancement for MCP hooks)
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes
useRenderDatahook with anallowedOriginsarray (e.g.,['https://mongodb.com']).window.dispatchEvent(new MessageEvent('message', { ... }))from an origin not in the list. Observe that the state remains unchanged.renderDatais updated as expected.useRenderData.spec.tsxhave been updated to cover these scenarios.