fix(NODE-7354): eagerly make Binary sub_type into a number#858
Open
nbbeeken wants to merge 2 commits intomongodb:mainfrom
Open
fix(NODE-7354): eagerly make Binary sub_type into a number#858nbbeeken wants to merge 2 commits intomongodb:mainfrom
nbbeeken wants to merge 2 commits intomongodb:mainfrom
Conversation
addaleax
previously approved these changes
Jan 5, 2026
PavelSafronov
previously approved these changes
Jan 7, 2026
dariakp
requested changes
Jan 8, 2026
Contributor
There was a problem hiding this comment.
@PavelSafronov Let's align as a team before accepting the change. We currently have this in the backlog, hence the "wip" label. We also have it as an improvement in jira, so "fix" might not be the correct tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
Even with the ctor fix I still changed the error message bc the sub_type is writable.
What is the motivation for this change?
Improved error message for debugging and improved construction for consistency with serializer.
Release Highlight
new Binary(buffer, subType)now coercessubTypeto match BSON bytesThe Binary constructor now normalizes subtype inputs to match BSON serialization. Previously, passing a stringified subtype like
'4'would cause a mismatch between the sub_type property (string'4') and the serialized BSON value (0x04). The constructor now converts inputs to ensure consistency.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript