Reserve balance tests: authorization lists & SELFDESTRUCT

[pdobacz]

Adding two additional tests for the reserve balance I've gathered over the past days.

The first one is simple.

The other one is a bit convoluted, but essential to cover the init-selfdestruct scenarios. In a nutshell, an account is receiving its balance if various combinations of crediting calls and in the end SELFDESTRUCTs. Reserve balance should only be considered when the SELFDESTRUCT is done on behalf of a 7702 delegation.

[greptile-apps]

Greptile Summary

This PR adds two new test cases for Monad's reserve balance feature: test_delegated_eoa_auth_list (reserve balance across various EIP-7702 delegation sequences) and test_contract_unrestricted_with_selfdestruct (reserve balance for SELFDESTRUCT via 7702 delegation).

Key findings:

• any_delegation logic error (line 414): The condition pre_delegated or len(delegation_targets) > 0 incorrectly marks accounts as delegated when the auth list contains only undelegations or ends with an undelegation. The final delegation state should be determined by the last entry in the auth list, not by the mere presence of entries. This causes incorrect test expectations for cases like undelegate_twice and delegate_undelegate.

• Incomplete reverted post-state assertions (line 1636): When reverted=True, the post-state only verifies factory_address, leaving selfdestruct_target, delegated_address, and new_contract_address completely unchecked. This reduces the test's ability to detect bugs where balance is incorrectly transferred or accounts are incorrectly modified during a reverting transaction.

Confidence Score: 3/5

• Tests have logic errors in delegation detection and incomplete reverted-state assertions, reducing spec compliance assurance.
• The new tests cover important edge cases but contain two verified issues: (1) the any_delegation logic incorrectly marks accounts as delegated when the auth list contains only undelegations or ends with undelegation, causing incorrect test expectations for multiple parameter combinations; (2) the reverted branch of test_contract_unrestricted_with_selfdestruct does not assert several key accounts (selfdestruct_target, delegated_address, new_contract_address), which reduces the test's ability to detect bugs in the revert path. These are not test failures but logic/coverage gaps that weaken confidence in whether the tests fully validate the spec.
• tests/monad_eight/reserve_balance/test_transfers.py — specifically any_delegation logic around line 414 and reverted post-state assertions starting at line 1636.

_{Last reviewed commit: 9aac490}

[greptile-apps]

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}