Skip to content

Make settings page localizable#5294

Merged
Prospector merged 5 commits intomodrinth:mainfrom
xinyihl:settings-i18n
Mar 18, 2026
Merged

Make settings page localizable#5294
Prospector merged 5 commits intomodrinth:mainfrom
xinyihl:settings-i18n

Conversation

@xinyihl
Copy link
Copy Markdown
Contributor

@xinyihl xinyihl commented Feb 4, 2026

Adding Localization to Unlocalized Content on the Settings Page

@lumiscosity
Copy link
Copy Markdown
Contributor

lumiscosity commented Feb 4, 2026

for plan names, it might be beneficial to move them out from here to common messages, then use those everywhere:

small: {
buttonColor: 'blue',
accentText: 'text-blue',
accentBg: 'bg-bg-blue',
name: defineMessage({
id: 'servers.plan.small.name',
defaultMessage: 'Small',
}),
description: defineMessage({
id: 'servers.plan.small.description',
defaultMessage: 'Perfect for 1–5 friends with a few light mods.',
}),
mostPopular: false,
},
medium: {
buttonColor: 'green',
accentText: 'text-green',
accentBg: 'bg-bg-green',
name: defineMessage({
id: 'servers.plan.medium.name',
defaultMessage: 'Medium',
}),
description: defineMessage({
id: 'servers.plan.medium.description',
defaultMessage: 'Great for 6–15 players and multiple mods.',
}),
mostPopular: true,
},
large: {
buttonColor: 'purple',
accentText: 'text-purple',
accentBg: 'bg-bg-purple',
name: defineMessage({
id: 'servers.plan.large.name',
defaultMessage: 'Large',
}),
description: defineMessage({
id: 'servers.plan.large.description',
defaultMessage: 'Ideal for 15–25 players, modpacks, or heavy modding.',
}),
mostPopular: false,
},
}

@IMB11 IMB11 added i18n frontend Involves work from the frontend team 📂 Under review [Triage] Is being reviewed by Modrinth Staff for future roadmap consideration. labels Feb 4, 2026
Comment thread packages/ui/src/utils/common-messages.ts Outdated
@Prospector Prospector changed the title Make Localization Make settings page localizable Mar 17, 2026
@Prospector
Copy link
Copy Markdown
Member

If you're still interested in seeing this PR merged, would be be possible for you to update it and resolve the conflicts?

@xinyihl
Copy link
Copy Markdown
Contributor Author

xinyihl commented Mar 18, 2026

Sure, let me take a look.

@Prospector Prospector enabled auto-merge March 18, 2026 16:09
@Prospector Prospector added this pull request to the merge queue Mar 18, 2026
Merged via the queue into modrinth:main with commit cf1b5f5 Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Involves work from the frontend team i18n 📂 Under review [Triage] Is being reviewed by Modrinth Staff for future roadmap consideration.

Development

Successfully merging this pull request may close these issues.

4 participants