fix: route broker.publish through fake client in TestOutboxBroker#9
Merged
Merged
Conversation
`broker.publish` / `publish_batch` / `cancel_timer` inside `TestOutboxBroker` previously went through SQLAlchemy `session.execute`, bypassing the patched `FakeOutboxClient` — the row landed in the real DB while subscriber loops polled the in-memory fake, so handlers never fired. Patch all three methods in `_patch_broker` to route to the fake; `session` becomes optional in test mode, matching FastStream's standard test-broker idiom. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broker.publish/publish_batch/cancel_timerinsideTestOutboxBrokerpreviously went through SQLAlchemysession.execute, bypassing the patchedFakeOutboxClient— the row landed in the real DB while subscriber loops polled the in-memory fake, so handlers never fired. Patch all three methods in_patch_brokerto route to the fake;sessionbecomes optional in test mode, matching FastStream's standard test-broker idiom.