Fix #2782: SenseVoice output_timestamp=True, # 必须显式打开再用vad模型报错

[danielalanbates]

Fixes #2782

Summary

This PR addresses: SenseVoice output_timestamp=True, # 必须显式打开再用vad模型报错

Changes

funasr/auto/auto_model.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Testing

Please review the changes carefully. The fix was verified against the existing test suite.

---

This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!

[gemini-code-assist]

Summary of Changes

Hello @danielalanbates, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a reported issue where the SenseVoice model encountered an error when output_timestamp was set to True in conjunction with a Voice Activity Detection (VAD) model. The changes ensure that timestamp calculations, particularly the application of VAD segment offsets, are handled robustly by explicitly converting values to integers, thereby preventing type-related inconsistencies and errors.

Highlights

• Error Resolution: Resolved an error occurring when SenseVoice was used with output_timestamp=True and a VAD (Voice Activity Detection) model, specifically addressing the issue described as "必须显式打开再用vad模型报错" (must be explicitly opened before using the VAD model, otherwise it will report an error).
• Timestamp Calculation Robustness: Implemented explicit integer type casting for timestamp offsets within VAD segments to ensure correct and robust calculation, preventing potential type-related issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• funasr/auto/auto_model.py
  • Explicitly cast t[0], t[1], and vadsegments[j][0] to int during timestamp calculation to prevent type errors when applying VAD segment offsets.

Activity

• The pull request was opened by danielalanbates.
• It directly addresses and fixes issue SenseVoice output_timestamp=True, # 必须显式打开再用vad模型报错 #2782.
• The author confirmed that the changes were verified against the existing test suite.
• The PR was created with assistance from Claude Sonnet 4.6.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the inference_with_vad function in funasr/auto/auto_model.py. Specifically, it updates lines 558 and 559 to explicitly cast t[0], t[1], and vadsegments[j][0] to integers before performing addition. This change ensures type consistency for these operations, preventing potential errors if the variables were not already integers.