fix: throw SdkError for unsupported capabilities in assertCapability()#1676
Open
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: throw SdkError for unsupported capabilities in assertCapability()#1676kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…ic Error Replace the generic `throw new Error()` in `assertCapability()` with `throw new SdkError(SdkErrorCode.CapabilityNotSupported, ...)` so that callers can programmatically distinguish unsupported-capability errors from other failures without fragile message-string matching. Fixes modelcontextprotocol#430
🦋 Changeset detectedLatest commit: 95e2a96 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #430
The
assertCapability()method inClientwas throwing a genericErrorwhen a server doesn't support a required capability. This made it impossible for callers to programmatically distinguish unsupported-capability errors from other failures without fragile message-string matching.Changes
packages/client/src/client/client.ts: Replacethrow new Error(...)withthrow new SdkError(SdkErrorCode.CapabilityNotSupported, ...)inassertCapability(). This is consistent withassertCapabilityForMethod()which already usesSdkErrorwith the same error code.test/integration/test/client/client.test.ts: Add assertions verifying that the thrown error is an instance ofSdkErrorwithcode: SdkErrorCode.CapabilityNotSupported.Usage
Callers can now catch unsupported capability errors programmatically:
All 386 tests pass.