Skip to content

test: verify e2e ci workflow#353

Merged
plrthink merged 13 commits into
masterfrom
test/ci-e2e-workflow
May 19, 2026
Merged

test: verify e2e ci workflow#353
plrthink merged 13 commits into
masterfrom
test/ci-e2e-workflow

Conversation

@plrthink
Copy link
Copy Markdown
Collaborator

@plrthink plrthink commented May 19, 2026

This is a test PR to verify the new Maestro E2E workflow runs correctly on all 4 jobs (iOS/Android × RN/Expo).\n\nDo not merge — will be closed after checks complete.


Open in Devin Review

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread .github/workflows/e2e.yml
@@ -1,4 +1,5 @@
name: E2E Tests
# Test trigger for CI verification
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Leftover debug comment in workflow file

Line 2 adds # Test trigger for CI verification which appears to be a temporary comment used to trigger a CI run (a common pattern when testing workflow changes). This should probably be removed before merging to keep the workflow file clean.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

plrthink added 10 commits May 19, 2026 11:57
- Create ci-master.yaml that runs all E2E scenarios in one continuous
  session (single stopApp/launchApp), eliminating iOS race conditions
  and Android repeated cold-start slowness
- Increase home screen wait timeout from 45s to 120s for slow CI emulators
- Add Maestro debug artifact uploads on failure (screenshots, UI hierarchy)
- Add iOS crash log collection on failure
- Add Android logcat collection on failure
- Run single maestro test instead of 5 individual invocations
Extract setup and test logic into reusable sub-flows so CI and local
use the same assertions:

- _setup.yaml: stopApp, launchApp, dev-server selection, home wait
- _home-check.yaml: home screen element assertions
- _zip-test.yaml, _unzip-test.yaml, _password-test.yaml,
  _progress-test.yaml, _assets-test.yaml: feature-specific tests

Individual flows now compose setup + their test sub-flows.
ci-master.yaml composes setup + all test sub-flows in sequence.

This eliminates duplication and ensures CI and local always test
the same behavior.
…apture

The android-emulator-runner action runs each script line as a separate
sh -c invocation, so TEST_EXIT=0 and adb logcat never worked correctly.
Remove the broken logcat capture and rely on Maestro debug artifacts.

Increase extendedWaitUntil timeout from 120s to 180s for slow CI emulators.
@plrthink plrthink merged commit 340ea4b into master May 19, 2026
2 checks passed
@plrthink plrthink deleted the test/ci-e2e-workflow branch May 19, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant