fix(cli): show actionable error when package.json is missing "type": "module"#76
Open
fix(cli): show actionable error when package.json is missing "type": "module"#76
Conversation
…"module" Catch ERR_REQUIRE_ESM thrown by loadConfigFromFile and print a clear, human-readable message telling the user exactly what to add to their package.json, instead of dumping a raw Node.js internal stack trace.
e0440a8 to
8ce1010
Compare
12-gabrielnascimento
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mobilewright testwith a CJSpackage.json(missing"type": "module") dumps a raw Node.jsERR_REQUIRE_ESMstack trace with no hint about the fix.ERR_REQUIRE_ESMin the config-loading step and print a clear message telling the user exactly what to add to theirpackage.json."type": "module"or copies config from a CJS project.Error before this fix
Error after this fix
Test plan
npm test— 147 passed, 1 skipped)"type": "module"to confirm the friendly error is shownERR_REQUIRE_ESMerrors are still re-thrown as before