fix(driver): reject .ipa installs on iOS simulators with a clear error#74
Open
fix(driver): reject .ipa installs on iOS simulators with a clear error#74
Conversation
Add a proactive guard in installApp(): if the path ends in .ipa and the active session targets an iOS simulator, throw with actionable instructions for building a .zip of the .app bundle instead of propagating a cryptic mobilecli platform error downstream.
krismuhi
force-pushed
the
fix/driver-ipa-simulator-guard
branch
from
6f42270 to
52e076e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device.installApp()silently accepted a.ipapath when the target was an iOS simulator, then propagated a cryptic mobilecli platform error with no actionable guidance. This hit real users whoseinstallAppsconfig pointed to a device-only IPA archive.installApp()— if the path ends in.ipa(case-insensitive) and the active session is an iOS simulator, throw immediately with a clear error message that names the simulator and includes step-by-stepxcodebuild+zipinstructions for producing a.zipof the.appbundle..ipapaths (.zip,.apk, etc.).Test plan
packages/driver-mobilecli/src/driver.test.ts— 7 new unit tests covering:.ipatargeting iOS simulator (happy-path guard)xcodebuildandzipinstructions.IPAextension match.ipaon a real iOS device.zipon an iOS simulator.apkon an Android emulatornpm testpasses (157 tests, 1 pre-existing skip)