Add a script to check drop in all callers of out_of_memory#1477
Draft
qinsoon wants to merge 1 commit intommtk:masterfrom
Draft
Add a script to check drop in all callers of out_of_memory#1477qinsoon wants to merge 1 commit intommtk:masterfrom
qinsoon wants to merge 1 commit intommtk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script to parse Rust MIR to check if there is any
Dropon the call frames ofCollection::out_of_memory. This script can be used in CI to ensure throwing fromout_of_memoryis correct for the code base.Codex wrote the script. I didn't check the script, but the results from the script look reasonable.
Related: #1475