Throws errors when parsing invalid JSON#9
Open
refractalize wants to merge 6 commits intommalecki:masterfrom
Open
Throws errors when parsing invalid JSON#9refractalize wants to merge 6 commits intommalecki:masterfrom
refractalize wants to merge 6 commits intommalecki:masterfrom
Conversation
| } | ||
|
|
||
| JSONStream.prototype._transform = function(chunk, encoding, cb) { | ||
| this._buffer += this._decoder.write(chunk); |
Author
There was a problem hiding this comment.
@jcrugzz so you reckon this bit should do buffer concat, not string concat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've actually replaced the implementation with the one found on node's stream documentation. Hope this doesn't hurt anybody's egos ;)
Importantly however, this makes the stream throw an error (via
stream.on('error', ...)) if it meets a line in the input that isn't JSON (excluding whitespace only lines of course.)We fix this by waiting for a
\nbefore attempting to parse JSON, and finally by waiting for theendevent to parse any remaining text (if the file doesn't end with\n.) Theendevent is the_flush()method on theTransformstream.The module supports async and non-async modes, as before. (Although this needs some documentation... but I'm not really sure what situations you'd need one or the other.)