Open
Conversation
Collaborator
Author
|
@pinis-gini-apps, we will need to check diffs for the whole branch. Because git shows some changes where they should be, because they were on the development branch originally, but diffs show the opposite. And there are probably more changes that were missed or erased (from development), as we had with the Nuclio function name and the section table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🛠️ Changes Made
✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
Includes DRC change
If yes -> requires bump NPM version
🔍 Additional Notes
Comparing is not 100% accurate because git shows in some cases non-existing changes https://github.com/Taras-Hlukhovetskyi/ui/pull/271/changes#diff-aa6f2162e8caa9ddcba0ebe05eb6eefc92e75258b2472ef4436d4fdbf74da833
📸 Screenshots / Demos