Skip to content

Diff dev to igz4#3636

Open
Taras-Hlukhovetskyi wants to merge 3 commits intomlrun:feature/ig4from
Taras-Hlukhovetskyi:diff_dev_to-igz4
Open

Diff dev to igz4#3636
Taras-Hlukhovetskyi wants to merge 3 commits intomlrun:feature/ig4from
Taras-Hlukhovetskyi:diff_dev_to-igz4

Conversation

@Taras-Hlukhovetskyi
Copy link
Collaborator

📝 Description


🛠️ Changes Made


✅ Checklist

  • I have given the PR a well-structured title describing the domain and the specific change that was made
  • I tested the changes in the browser (locally or via preview build)
  • I confirmed that existing tests pass
  • I added or updated unit / integration tests (if needed)
  • I checked that this change doesn’t introduce new console warnings or lint / formatting errors
  • I updated the relevant Jira ticket with the appropriate details and status

🔗 References

  • Related ticket / issue:
  • Figma / design spec:
  • Documentation:

🚨 Potentially Breaking Changes

  • Yes
  • No

Includes DRC change

  • Yes
  • No

If yes -> requires bump NPM version


🔍 Additional Notes

Comparing is not 100% accurate because git shows in some cases non-existing changes https://github.com/Taras-Hlukhovetskyi/ui/pull/271/changes#diff-aa6f2162e8caa9ddcba0ebe05eb6eefc92e75258b2472ef4436d4fdbf74da833

📸 Screenshots / Demos


@Taras-Hlukhovetskyi
Copy link
Collaborator Author

@pinis-gini-apps, we will need to check diffs for the whole branch. Because git shows some changes where they should be, because they were on the development branch originally, but diffs show the opposite. And there are probably more changes that were missed or erased (from development), as we had with the Nuclio function name and the section table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant