Add pagination support to Web UI entity listing pages#672
Open
mhmdk0 wants to merge 4 commits intomlcommons:mainfrom
Open
Add pagination support to Web UI entity listing pages#672mhmdk0 wants to merge 4 commits intomlcommons:mainfrom
mhmdk0 wants to merge 4 commits intomlcommons:mainfrom
Conversation
mhmdk0
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
mhmdk0
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
reviewed
Apr 24, 2026
Comment on lines
+90
to
+91
| owner = "owner" in filters and filters["owner"] == get_medperf_user_data()["id"] | ||
| return config.comms.get_benchmarks_count, owner |
Contributor
There was a problem hiding this comment.
it's cleaner to have this "is_owner" logic written in the get_count method, not here. This method should be just "get_comms_counter" define in the top (beside get_comms_retriever etc...)
Comment on lines
+47
to
+55
| if ordering == "created_at_asc": | ||
| order = "created_at" | ||
| elif ordering == "name_asc": | ||
| order = "name" | ||
| elif ordering == "name_desc": | ||
| order = "-name" | ||
| else: | ||
| order = "-created_at" | ||
|
|
Contributor
There was a problem hiding this comment.
let's move this to a common util file
Comment on lines
+92
to
+98
| "page": page, | ||
| "page_size": page_size, | ||
| "total_pages": total_pages, | ||
| "ordering": ordering, | ||
| "total_count": total_count, | ||
| "start_index": start_index, | ||
| "end_index": end_index, |
Contributor
There was a problem hiding this comment.
can we move all the ordering/pagination logic to a common file and have it return a dictionary (page page_size total_pages ordering total_count start_index end_index)?
Comment on lines
+37
to
+78
| {% if benchmarks %} | ||
| <div class="container mt-5"> | ||
| <div class="row align-items-end justify-content-between g-3"> | ||
| <div class="col-md-3"> | ||
| <label class="form-label fw-semibold">Sort by</label> | ||
| <select class="form-select" id="ordering"> | ||
| <option value="created_at_desc" {% if ordering == "created_at_desc" %}selected{% endif %}> | ||
| Newest first | ||
| </option> | ||
| <option value="created_at_asc" {% if ordering == "created_at_asc" %}selected{% endif %}> | ||
| Oldest first | ||
| </option> | ||
| <option value="name_asc" {% if ordering == "name_asc" %}selected{% endif %}> | ||
| Name (A → Z) | ||
| </option> | ||
| <option value="name_desc" {% if ordering == "name_desc" %}selected{% endif %}> | ||
| Name (Z → A) | ||
| </option> | ||
| </select> | ||
| </div> | ||
| <div class="col-md-3"> | ||
| <label class="form-label fw-semibold">Items per page</label> | ||
| <select class="form-select" id="page-size"> | ||
| {% for size in [6, 9, 12, 24] %} | ||
| <option value="{{ size }}" {% if page_size == size %}selected{% endif %}> | ||
| {{ size }} | ||
| </option> | ||
| {% endfor %} | ||
| </select> | ||
| </div> | ||
| <div class="col-md-6 text-md-end text-muted"> | ||
| {% if total_count %} | ||
| <small> | ||
| Showing | ||
| <strong>{{ start_index }}</strong>-<strong>{{ end_index }}</strong> | ||
| of <strong>{{ total_count }}</strong> benchmarks | ||
| </small> | ||
| {% endif %} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| {% endif %} |
Contributor
There was a problem hiding this comment.
can we move this to a common partial?
Comment on lines
+94
to
+110
| {% if benchmarks and total_pages > 1 %} | ||
| <nav class="mt-4"> | ||
| <ul class="pagination justify-content-center"> | ||
| <li class="page-item {% if page == 1 %}disabled{% endif %}"> | ||
| <a class="page-link" href="#" data-page="{{ page - 1 }}">Previous</a> | ||
| </li> | ||
| {% for p in range(1, total_pages + 1) %} | ||
| <li class="page-item {% if p == page %}active{% endif %}"> | ||
| <a class="page-link" href="#" data-page="{{ p }}">{{ p }}</a> | ||
| </li> | ||
| {% endfor %} | ||
| <li class="page-item {% if page == total_pages %}disabled{% endif %}"> | ||
| <a class="page-link" href="#" data-page="{{ page + 1 }}">Next</a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| {% endif %} |
Contributor
There was a problem hiding this comment.
can we move this to a common partial?
Comment on lines
+115
to
+146
| function reloadUi(page = 1) { | ||
| if (page < 1 || !Number.isInteger(page)) return; | ||
|
|
||
| const params = new URLSearchParams({page: page, mine_only: $("#switch").is(":checked")}); | ||
| const locParams = new URLSearchParams(window.location.search); | ||
|
|
||
| const pageSize = $("#page-size").val(); | ||
| if (pageSize !== undefined && pageSize !== "") { | ||
| params.append("page_size", pageSize); | ||
| } | ||
| else if (locParams.get("page_size")) { | ||
| params.append("page_size", locParams.get("page_size")); | ||
| } | ||
|
|
||
| const ordering = $("#ordering").val(); | ||
| if (ordering !== undefined && ordering !== "") { | ||
| params.append("ordering", ordering); | ||
| } | ||
| else if (locParams.get("ordering")) { | ||
| params.append("ordering", locParams.get("ordering")); | ||
| } | ||
|
|
||
| window.location = `/benchmarks/ui?${params.toString()}`; | ||
| } | ||
|
|
||
| $("#ordering, #page-size, #switch").on("change", () => reloadUi(1)); | ||
|
|
||
| $(".page-link").on("click", function (e) { | ||
| e.preventDefault(); | ||
| const page = $(this).data("page"); | ||
| if (page) reloadUi(page); | ||
| }); |
Contributor
There was a problem hiding this comment.
can we move this to a common js file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
limitandoffset