Skip to content

🎨 Palette: Mobile Navigation i18n & Accessibility Polish#13

Open
MilakyS wants to merge 5 commits into
mainfrom
palette-mobile-nav-polish-9899656638758555980
Open

🎨 Palette: Mobile Navigation i18n & Accessibility Polish#13
MilakyS wants to merge 5 commits into
mainfrom
palette-mobile-nav-polish-9899656638758555980

Conversation

@MilakyS
Copy link
Copy Markdown
Member

@MilakyS MilakyS commented May 9, 2026

💡 What:

  • Moved data-i18n attributes to dedicated <span> elements for all navigation links.
  • Implemented background scroll locking when the mobile menu is active.
  • Added Escape key support for closing the mobile menu.

🎯 Why:

  • Prevents icons in the mobile menu from being deleted when the language is changed.
  • Improves focus and interaction stability on mobile by preventing background scrolling.
  • Enhances accessibility by providing a standard keyboard shortcut for closing overlays.

♿ Accessibility:

  • Added Escape key listener for modal-like menu dismissal.
  • Locked background scroll to maintain focus within the active overlay.
  • Ensured semantic structure is maintained during language transitions.

PR created automatically by Jules for task 9899656638758555980 started by @MilakyS

Co-authored-by: MilakyS <155958485+MilakyS@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 9, 2026

Deploy Preview for melodious-queijadas-3cc817 ready!

Name Link
🔨 Latest commit 63ef40f
🔍 Latest deploy log https://app.netlify.com/projects/melodious-queijadas-3cc817/deploys/6a023c12f5f91300085bbad7
😎 Deploy Preview https://deploy-preview-13--melodious-queijadas-3cc817.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 9, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
mks-lang 63ef40f May 11 2026, 08:29 PM

google-labs-jules Bot and others added 4 commits May 9, 2026 05:49
Co-authored-by: MilakyS <155958485+MilakyS@users.noreply.github.com>
Co-authored-by: MilakyS <155958485+MilakyS@users.noreply.github.com>
Co-authored-by: MilakyS <155958485+MilakyS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant