Skip to content

ci: guard publish artifact verification for partial manifests#847

Merged
mk3008 merged 1 commit into
mainfrom
codex/improve-starter-onboarding-errors
May 22, 2026
Merged

ci: guard publish artifact verification for partial manifests#847
mk3008 merged 1 commit into
mainfrom
codex/improve-starter-onboarding-errors

Conversation

@mk3008
Copy link
Copy Markdown
Owner

@mk3008 mk3008 commented May 22, 2026

Summary

  • Skip the rawsql-ts getting-started smoke when the publish manifest does not include a rawsql-ts tarball.
  • Rebind generated scaffold local file dependencies to packed tarballs or published npm ranges before publish artifact smoke installs.
  • Reset npm lock/install state after dependency rebinding so verification does not keep stale local file links.

Verification

  • pnpm --filter @rawsql-ts/ztd-cli test -- publishWorkflow.unit.test.ts
  • node --check scripts/verify-published-package-mode.mjs
  • git diff --check
  • node ./scripts/verify-published-package-mode.mjs --publish-manifest tmp/ci-artifacts-26295661007/publish-manifest.json

Merge Readiness

  • No baseline exception requested.
  • Baseline exception requested and linked below.

Tracking issue: not needed; no baseline exception requested.
Scoped checks run: publish artifact verification failure was reproduced with the downloaded run artifact and targeted script/test checks were run.
Why full baseline is not required: CI fix is limited to publish artifact verification script behavior and its publishWorkflow unit coverage.

Self Review

Self-review workflow: Focused self-review of the CI failure path, manifest-gated smoke behavior, and dependency rebinding behavior.
Self-review result: No unresolved blockers; downloaded failing artifact now verifies successfully with the updated script.
Concept-review workflow: Concept boundary check classified this as technical-support CI verification work with no business-bearing artifact changes.
Concept-review result: No ConceptSpec or ztd-cli runtime-free boundary violation; change only affects publish artifact verification mechanics.

CLI Surface Migration

  • No migration packet required for this CLI change.
  • CLI/user-facing surface change and migration packet completed.

No-migration rationale: No CLI command, generated user surface, or documented workflow changes.
Upgrade note: No user action required.
Deprecation/removal plan or issue: No deprecation or removal.
Docs/help/examples updated: Not needed; internal CI verification script only.
Release/changeset wording: No changeset needed; publish CI verification fix only.

Scaffold Contract Proof

  • No scaffold contract proof required for this PR.
  • Scaffold contract proof completed.

No-proof rationale: This does not change scaffold generation contracts; it only makes publish artifact verification avoid local-source dependency leakage.
Non-edit assertion: No generated scaffold templates were edited.
Fail-fast input-contract proof: publishWorkflow unit test asserts manifest-gated rawsql-ts smoke and dependency rebinding behavior.
Generated-output viability proof: Downloaded failed publish artifact manifest was re-run through verify-published-package-mode successfully.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@mk3008 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d8fd22e-5e94-4b44-9289-5d45e9a7b675

📥 Commits

Reviewing files that changed from the base of the PR and between 8d60bd8 and 03203b8.

📒 Files selected for processing (2)
  • packages/ztd-cli/tests/publishWorkflow.unit.test.ts
  • scripts/verify-published-package-mode.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-starter-onboarding-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mk3008 mk3008 force-pushed the codex/improve-starter-onboarding-errors branch from 537c20c to 03203b8 Compare May 22, 2026 15:22
@mk3008 mk3008 merged commit 1e8f4c1 into main May 22, 2026
10 checks passed
@mk3008 mk3008 deleted the codex/improve-starter-onboarding-errors branch May 22, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant