Conversation
Added delaymessage command stop command in development
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
@kudelek are these changes relevant? Let's delete them if not :)
| setTimeout(action, minDelay); | ||
| } | ||
|
|
||
| function action() { |
There was a problem hiding this comment.
Could we import the message.js command and reuse its handler function here instead?
| } else { | ||
| //return getThreadByName(messer.messen, rawReceiver) | ||
| //.then(thread => | ||
| console.log( |
There was a problem hiding this comment.
Because we're leveraging the Node.js repl, we should instead return the resolve function like so:
return resolve(`Message will send in ${rawDelay} minutes`);
|
|
||
| if (!argv || !argv[1]) { | ||
| return Promise.reject(Error("Invalid command - check your syntax")); | ||
| return Promise.reject(Error("Invalid command - check your syntax0")); |
There was a problem hiding this comment.
Any reason to change this?
| "test": "NODE_ENV=test && npm run lint && npm run test-unit" | ||
| }, | ||
| "dependencies": { | ||
| "@types/minimist": "file:minimist", |
There was a problem hiding this comment.
Do we need to have this?
|
Hey @kudelek this is such an awesome addition! Thanks for working on it. I've left some comments for your consideration, let me know when you'd like me to take another look 🏓 |
|
Hey @tomquirk! Sorry for such late response. Thank you for your review of my addition. To be honest, I didn't expect my addition to be considered. I was just curious if it could be possible to delay messages on messenger, so i tried it here :) . I'll reply to your previous comments soon. PS, I planned to extend this delaymessage option i.e. to be canceled. Maybe I'll do it in the future |
|
I've tried to check some changes, but now I'm unable to log in with messer. I'll do it once I solve the problem on my side. |
2 participants
Added delaymessage command, to delay a message by a certain number of minutes