Skip to content

Removed runtime.txt and fixed poetry.lock#5349

Open
rhysyngsun wants to merge 2 commits intomasterfrom
nl/fix-heroku-deploys
Open

Removed runtime.txt and fixed poetry.lock#5349
rhysyngsun wants to merge 2 commits intomasterfrom
nl/fix-heroku-deploys

Conversation

@rhysyngsun
Copy link
Copy Markdown
Contributor

@rhysyngsun rhysyngsun commented Sep 21, 2023

What are the relevant tickets?

N/A

Description (What does it do?)

This fixes the heroku deployments that broke due to the switch to Poetry:

  • Removes runtime.txt since Heroku is erroring on it being present since Heroku just reads the runtime from pyproject.toml.
  • Ran poetry lock --no-update since Heroku is generating a warning for this
  • Added poetry lock --check to the CI actions so that we catch lockfile issues before they get merged.
  • Fixed indentation issue in ci.yaml.

How can this be tested?

  • Tests should pass

@rhysyngsun rhysyngsun force-pushed the nl/fix-heroku-deploys branch 3 times, most recently from a277455 to 1678071 Compare September 21, 2023 18:41
@rhysyngsun rhysyngsun force-pushed the nl/fix-heroku-deploys branch from 1678071 to 19be438 Compare September 21, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant