Skip to content

chore: remove unnecessary opentelemetry-sdk and exporter dependencies #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nelson-PROIA merged 1 commit into from
Mar 9, 2026
+0 −95
Merged

chore: remove unnecessary opentelemetry-sdk and exporter dependencies #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ dependencies = [
"typing-inspection >=0.4.0",
"pyyaml (>=6.0.2,<7.0.0)",
"invoke (>=2.2.0,<3.0.0)",
Comment on lines 14 to 15
Copy link
Copy Markdown
Contributor

@simonvdk-mistral simonvdk-mistral Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of the context of OTEL dependencies, but looks like both pyyaml and invoke should rather be dev dependencies ?

"opentelemetry-sdk (>=1.33.1,<2.0.0)",
"opentelemetry-api (>=1.33.1,<2.0.0)",
"opentelemetry-exporter-otlp-proto-http (>=1.37.0,<2.0.0)",
"opentelemetry-semantic-conventions (>=0.59b0,<0.61)",
]

Expand Down
6 changes: 0 additions & 6 deletions src/mistralai/extra/observability/otel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import opentelemetry.semconv._incubating.attributes.http_attributes as http_attributes
import opentelemetry.semconv.attributes.server_attributes as server_attributes
from opentelemetry import propagate, trace
from opentelemetry.sdk.trace import SpanProcessor
from opentelemetry.trace import Span, Status, StatusCode, Tracer, set_span_in_context

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -201,11 +200,6 @@ def enrich_span_from_response(tracer: trace.Tracer, span: Span, operation_id: st
span.set_attributes(ocr_attributes)


class GenAISpanProcessor(SpanProcessor):
def on_start(self, span, parent_context = None):
span.set_attributes({"agent.trace.public": ""})


def get_or_create_otel_tracer() -> tuple[bool, Tracer]:
"""
Get a tracer from the current TracerProvider.
Expand Down
87 changes: 0 additions & 87 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.