fix: use request.content instead of request._content in otel span enrichment#402
Closed
MaxwellCalkin wants to merge 1 commit intomistralai:mainfrom
Closed
fix: use request.content instead of request._content in otel span enrichment#402MaxwellCalkin wants to merge 1 commit intomistralai:mainfrom
MaxwellCalkin wants to merge 1 commit intomistralai:mainfrom
Conversation
…ichment httpx 0.28.1 removed the private `_content` attribute from Request objects, causing an AttributeError in `enrich_span_from_request()` and `get_response_and_error()`. Use the public `.content` property instead, which is the stable httpx API for accessing raw request/response bytes. Fixes mistralai#347 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the fix — this is a real issue. We're addressing it as part of the broader OTEL rework in #407. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #347.
enrich_span_from_request()andget_response_and_error()inotel.pyaccessrequest._contentandresponse._content, which are private httpx internals. httpx 0.28.1 removed_contentfromRequestobjects, causing anAttributeErrorwhenever OpenTelemetry tracing is enabled:This PR replaces all four
._contentaccesses with the public.contentproperty, which is the stable httpx API for accessing raw request/response bytes.Changes
request._content->request.content(lines 94-95)hasattr(response, "_content") and response._content->response.content(lines 304-305) — thehasattrguard is no longer needed since.contentis always available onhttpx.Response🤖 Generated with Claude Code