chore: remove unnecessary opentelemetry dependencies#401
Closed
BjoernPetersen wants to merge 1 commit intomistralai:mainfrom
Closed
chore: remove unnecessary opentelemetry dependencies#401BjoernPetersen wants to merge 1 commit intomistralai:mainfrom
BjoernPetersen wants to merge 1 commit intomistralai:mainfrom
Conversation
The opentelemetry SDK and exporter protocols should be installed by applications, not libraries/packages
Contributor
|
Thanks for the contribution, we'll review as soon as possible. (ci failure due to obsolete API key) |
2 tasks
Contributor
|
Done in #406. Thanks for the tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opentelemetry SDK and exporter protocols should be installed by applications, not libraries/packages. See also the OpenTelemetry docs on this.
The only SDK import was in
mistralai.extra.observability.otel, to create aGenAISpanProcessorsubclass that was never used anywhere.