Skip to content

Fix: AP Inbox 処理において凍結・削除のチェックが一部対称となっていなかったのを修正#17394

Draft
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:fix/no-check-isDeleted-pr
Draft

Fix: AP Inbox 処理において凍結・削除のチェックが一部対称となっていなかったのを修正#17394
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:fix/no-check-isDeleted-pr

Conversation

@samunohito
Copy link
Copy Markdown
Member

@samunohito samunohito commented May 12, 2026

What

Why

fix #17393

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.87%. Comparing base (3074784) to head (8b0be54).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 0 Missing and 2 partials ⚠️
...ckend/src/core/activitypub/models/ApNoteService.ts 71.42% 2 Missing ⚠️
...kend/src/queue/processors/InboxProcessorService.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17394      +/-   ##
===========================================
+ Coverage    15.26%   24.87%   +9.60%     
===========================================
  Files          245     1155     +910     
  Lines        12288    39308   +27020     
  Branches      4162    10945    +6783     
===========================================
+ Hits          1876     9776    +7900     
- Misses        8152    23667   +15515     
- Partials      2260     5865    +3605     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 300.70 MB 302.48 MB +1.77 MB +0.59%
VmHWM 300.70 MB 302.48 MB +1.77 MB +0.59%
VmSize 23077.77 MB 23080.53 MB +2.76 MB +0.01%
VmData 1343.89 MB 1345.99 MB +2.09 MB +0.15%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 300.73 MB 302.48 MB +1.74 MB +0.58%
VmHWM 300.73 MB 302.48 MB +1.74 MB +0.58%
VmSize 23077.85 MB 23080.53 MB +2.67 MB +0.01%
VmData 1343.98 MB 1345.99 MB +2.01 MB +0.14%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 301.47 MB 302.73 MB +1.26 MB +0.41%
VmHWM 301.47 MB 302.73 MB +1.26 MB +0.41%
VmSize 23078.35 MB 23080.53 MB 2.17 MB 0%
VmData 1344.48 MB 1345.91 MB +1.43 MB +0.10%

See workflow logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

ActivityPub Inbox 処理で凍結ユーザの考慮はされているが論理削除ユーザのチェックが漏れている個所がある

1 participant