Skip to content

feat: 投稿通知設定したユーザーをリストで見ることができるように#17385

Merged
syuilo merged 3 commits into
misskey-dev:developfrom
4ster1sk:feat/notify-user-list
May 12, 2026
Merged

feat: 投稿通知設定したユーザーをリストで見ることができるように#17385
syuilo merged 3 commits into
misskey-dev:developfrom
4ster1sk:feat/notify-user-list

Conversation

@4ster1sk
Copy link
Copy Markdown
Contributor

@4ster1sk 4ster1sk commented May 9, 2026

What

「設定」→「通知」から投稿を通知する設定したユーザーをリストで見られるようになります

Why

だれを登録したかわからなくなるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 9, 2026
@github-actions github-actions Bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/backend:test labels May 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.15%. Comparing base (717931c) to head (8e7e12a).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/server/api/endpoints/users/notify/list.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17385      +/-   ##
===========================================
+ Coverage    15.22%   25.15%   +9.92%     
===========================================
  Files          247     1158     +911     
  Lines        12322    39538   +27216     
  Branches      4174    10977    +6803     
===========================================
+ Hits          1876     9945    +8069     
- Misses        8183    23722   +15539     
- Partials      2263     5871    +3608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -85289,6 +85289,177 @@
         }
       }
     },
+    "/users/notify/list": {
+      "post": {
+        "operationId": "post___users___notify___list",
+        "summary": "users/notify/list",
+        "description": "List of following users with notification enabled.\n\n**Credential required**: *Yes* / **Permission**: *read:following*",
+        "externalDocs": {
+          "description": "Source code",
+          "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/users/notify/list.ts"
+        },
+        "tags": [
+          "users"
+        ],
+        "security": [
+          {
+            "bearerAuth": []
+          }
+        ],
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "sinceId": {
+                    "type": "string",
+                    "format": "misskey:id"
+                  },
+                  "untilId": {
+                    "type": "string",
+                    "format": "misskey:id"
+                  },
+                  "sinceDate": {
+                    "type": "integer"
+                  },
+                  "untilDate": {
+                    "type": "integer"
+                  },
+                  "limit": {
+                    "type": "integer",
+                    "minimum": 1,
+                    "maximum": 100,
+                    "default": 10
+                  }
+                }
+              }
+            }
+          }
+        },
+        "responses": {
+          "200": {
+            "description": "OK (with results)",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "array",
+                  "items": {
+                    "$ref": "#/components/schemas/UserDetailed"
+                  }
+                }
+              }
+            }
+          },
+          "400": {
+            "description": "Client error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "INVALID_PARAM": {
+                    "value": {
+                      "error": {
+                        "message": "Invalid param.",
+                        "code": "INVALID_PARAM",
+                        "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "401": {
+            "description": "Authentication error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "CREDENTIAL_REQUIRED": {
+                    "value": {
+                      "error": {
+                        "message": "Credential required.",
+                        "code": "CREDENTIAL_REQUIRED",
+                        "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "403": {
+            "description": "Forbidden error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "AUTHENTICATION_FAILED": {
+                    "value": {
+                      "error": {
+                        "message": "Authentication failed. Please ensure your token is correct.",
+                        "code": "AUTHENTICATION_FAILED",
+                        "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "418": {
+            "description": "I'm Ai",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "I_AM_AI": {
+                    "value": {
+                      "error": {
+                        "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
+                        "code": "I_AM_AI",
+                        "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "500": {
+            "description": "Internal server error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "INTERNAL_ERROR": {
+                    "value": {
+                      "error": {
+                        "message": "Internal error occurred. Please contact us if the error persists.",
+                        "code": "INTERNAL_ERROR",
+                        "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    },
     "/users/pages": {
       "post": {
         "operationId": "post___users___pages",

Get diff files from Workflow Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 317.01 MB 317.15 MB +0.14 MB +0.04%
VmHWM 317.01 MB 317.15 MB +0.14 MB +0.04%
VmSize 23163.73 MB 23163.01 MB -0.71 MB 0%
VmData 1363.15 MB 1362.81 MB -0.34 MB -0.02%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 317.02 MB 317.17 MB +0.15 MB +0.04%
VmHWM 317.02 MB 317.17 MB +0.15 MB +0.04%
VmSize 23163.98 MB 23163.35 MB -0.63 MB 0%
VmData 1363.40 MB 1363.14 MB -0.25 MB -0.01%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 317.45 MB 317.67 MB +0.22 MB +0.06%
VmHWM 317.45 MB 317.71 MB +0.26 MB +0.08%
VmSize 23164.15 MB 23163.68 MB -0.46 MB 0%
VmData 1363.57 MB 1363.48 MB -0.09 MB 0%

See workflow logs for details

@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 12, 2026

・pれヴぃえw

@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 12, 2026

/preview

Comment on lines +43 to +47
signinRequired: {
message: 'Signin required.',
code: 'SIGNIN_REQUIRED',
id: '9748b741-4742-4a34-97d4-c5abcb537ca4',
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使われていないので不要と思われます

Comment on lines +31 to +41
noSuchUser: {
message: 'No such user.',
code: 'NO_SUCH_USER',
id: '63e4aba4-4156-4e53-be25-c9559e42d71b',
},

forbidden: {
message: 'Forbidden.',
code: 'FORBIDDEN',
id: 'f6cdb0df-c19f-ec5c-7dbb-0ba84a1f92ba',
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDが他の実装とかぶっているみたいです

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment on lines +222 to +231
.chevron {
display: block;
transition: transform 0.1s ease-out;
}

.userItem.userItemOpend {
.chevron {
transform: rotateX(180deg);
}
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

該当するクラスがなさそうに見えます

@4ster1sk
Copy link
Copy Markdown
Contributor Author

修正しましたー🙇‍♀️

@syuilo syuilo merged commit 6665c39 into misskey-dev:develop May 12, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 May 12, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 12, 2026

👍

@4ster1sk 4ster1sk deleted the feat/notify-user-list branch May 12, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants