revert: remove MemoryExtensions.Contains handling from QueryConverter#82
Closed
korchak-aleksandr wants to merge 1 commit intomainfrom
Closed
revert: remove MemoryExtensions.Contains handling from QueryConverter#82korchak-aleksandr wants to merge 1 commit intomainfrom
korchak-aleksandr wants to merge 1 commit intomainfrom
Conversation
Mindbox.Framework now normalizes MemoryExtensions.Contains to Enumerable.Contains before expressions reach data-linq, making this dead code for our stack.
Collaborator
Author
|
Closing: wrong direction. PR #81 (FindArrayInClosure display class fix) is the correct approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
TryExtractArrayFromSpanExpression,FindArrayInClosure, and theMemoryExtensions.Containsbranch inVisitMethodCalladded in #76 and #80.Also removes
ArrayContainsTranslationTests.cs.Why
Mindbox.Framework now normalizes
MemoryExtensions.Contains(ReadOnlySpan<T>.op_Implicit(array), value)→Enumerable.Contains(array, value)before expressions reach data-linq. This makes the QueryConverter logic dead code for our stack.The normalization happens in
MemoryExtensionsContainsNormalizerwhich runs insideQueryableExpanderprior toExpandExpressions().Version bump
10.8.1 → 10.8.2