-
Notifications
You must be signed in to change notification settings - Fork 1
Lib: Add api query #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PedroAraoz
wants to merge
5
commits into
main
Choose a base branch
from
lib-ts/add-api-query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−15
Open
Lib: Add api query #232
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@mimicprotocol/lib-ts": patch | ||
| "@mimicprotocol/cli": patch | ||
| "@mimicprotocol/test-ts": patch | ||
| --- | ||
|
|
||
| Add api query |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { Result } from '../types' | ||
|
PedroAraoz marked this conversation as resolved.
|
||
|
|
||
| import { QueryResponseBase } from './QueryResponse' | ||
|
|
||
| @json | ||
| class ApiQueryBase { | ||
| constructor(public readonly url: string) {} | ||
| } | ||
|
|
||
| @json | ||
| export class ApiQuery extends ApiQueryBase { | ||
| public readonly timestamp: i64 | ||
|
|
||
| constructor(url: string, timestamp: i64) { | ||
| super(url) | ||
| this.timestamp = timestamp | ||
| } | ||
|
|
||
| static from(url: string, timestamp: Date | null): ApiQueryBase { | ||
| return timestamp ? new ApiQuery(url, changetype<Date>(timestamp).getTime()) : new ApiQueryBase(url) | ||
| } | ||
| } | ||
|
|
||
| @json | ||
| export class ApiQueryResponse extends QueryResponseBase { | ||
| public data: string | ||
|
|
||
| constructor(success: string, data: string, error: string) { | ||
| super(success, error) | ||
| this.data = data | ||
| } | ||
|
|
||
| toResult(): Result<string, string> { | ||
| return this.buildResult<string>(this.data, 'Unknown error getting API response') | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { ApiQueryResponse } from '../../src/queries' | ||
|
|
||
| describe('ApiQueryResponse', () => { | ||
| describe('toResult', () => { | ||
| describe('when response is successful', () => { | ||
| describe('when data is provided', () => { | ||
| it('should return result with data', () => { | ||
| const responseData = '{"test": true}' | ||
| const response = new ApiQueryResponse('true', responseData, '') | ||
| const result = response.toResult() | ||
|
|
||
| expect(result.isOk).toBe(true) | ||
| const data = result.unwrap() | ||
| expect(data).toBe(responseData) | ||
| }) | ||
| }) | ||
|
|
||
| describe('when data is empty', () => { | ||
| it('should return empty string', () => { | ||
| const response = new ApiQueryResponse('true', '', '') | ||
| const result = response.toResult() | ||
|
|
||
| expect(result.isOk).toBe(true) | ||
| const data = result.unwrap() | ||
| expect(data).toBe('') | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('when response is not successful', () => { | ||
| describe('when error message is provided', () => { | ||
| it('should return error with provided message', () => { | ||
| const errorMessage = 'Something went wrong' | ||
| const response = new ApiQueryResponse('false', '', errorMessage) | ||
| const result = response.toResult() | ||
|
|
||
| expect(result.isError).toBe(true) | ||
| expect(result.error).toBe(errorMessage) | ||
| }) | ||
| }) | ||
|
|
||
| describe('when error message is not provided', () => { | ||
| it('should return default error message', () => { | ||
| const response = new ApiQueryResponse('false', '', '') | ||
| const result = response.toResult() | ||
|
|
||
| expect(result.isError).toBe(true) | ||
| expect(result.error).toBe('Unknown error getting API response') | ||
| }) | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.