feat: add feature flag Kustomize config and feature-flag-operator IAM role#597
Closed
kevwilliams wants to merge 1 commit into
Closed
feat: add feature flag Kustomize config and feature-flag-operator IAM role#597kevwilliams wants to merge 1 commit into
kevwilliams wants to merge 1 commit into
Conversation
… role Add config/services/features/ mirroring the quota service structure to support feature flag management via the quota ResourceRegistration API. Key changes: - Add features/iam/roles/feature-flag-operator.yaml: Role granting the minimum quota permissions needed to manage feature flags — read access to ResourceRegistrations and AllowanceBuckets, full CRUD on ResourceGrants (the mechanism used to grant flags to organizations) - Add features/registrations/kustomization.yaml: Placeholder component with an inline comment documenting the canonical ResourceRegistration shape future flags must follow (type=Feature, consumerType=Organization, claimingResources sentinel of FeatureGrant) - Wire features into config/services/kustomization.yaml aggregate Closes #576
Contributor
scotwells
reviewed
May 5, 2026
Contributor
There was a problem hiding this comment.
@kevwilliams we already have an existing role that covers this
https://github.com/datum-cloud/milo/blob/main/config/services/quota/iam/roles/quota-manager.yaml
Contributor
Author
|
Closing — the IAM role is a subset of the existing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/services/features/directory mirroring the quota service structure to support feature flag management via the quota ResourceRegistration APIfeature-flag-operatorIAM Role granting minimum quota permissions needed to manage feature flags (read on ResourceRegistrations + AllowanceBuckets, full CRUD on ResourceGrants)registrations/component with inline documentation of the canonical ResourceRegistration shape for future feature flagsfeaturesinto the top-levelconfig/services/kustomization.yamlaggregate componentContext
type=Featureis valid in the CRD as of feat(quota): add Feature to ResourceRegistration type enum #575datum-cloud/infra, not hereCloses #576
Test plan
kustomize build config/services/features/produces a single Role resource with the expected permissionskustomize build config/services/includes the new Role without errorsfeature-flag-operatorpermissions match the spec:resourceregistrationsget/list/watch,resourcegrantsget/list/watch/create/update/delete,allowancebucketsget/list/watch