fix: restore @datum-cloud/datum-ui to runtime dependencies#197
Merged
Conversation
The activity-ui example app (served as the activity-ui pod) is crashing in staging with CrashLoopBackOff (272+ restarts) because the Docker image is missing the @datum-cloud/datum-ui package at runtime: Error: Cannot find package '@datum-cloud/datum-ui' imported from /app/build/server/index.js The Dockerfile uses `pnpm deploy --filter activity-ui-example --prod` which only copies `dependencies` into the production image. When PR #194 promoted @datum-cloud/datum-ui to a peer dependency of the activity-ui library, it was never added to the example app's own `dependencies`, so pnpm deploy excluded it from the container. Fix: add @datum-cloud/datum-ui ^0.8.0 to dependencies in ui/example/package.json so it is included in the production image build.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kevwilliams
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
activity-uipod in staging is in CrashLoopBackOff (272+ restarts) with the following error:Root Cause
PR #194 promoted
@datum-cloud/datum-uito a peer dependency of the@datum-cloud/activity-uilibrary (ui/package.json) — which is correct for the published package. However, the example app (ui/example/package.json) was never updated to include@datum-cloud/datum-uiin its owndependencies.The Dockerfile builds the image using
pnpm deploy --filter activity-ui-example --prod, which only copiesdependencies(notdevDependenciesor peer dependencies of workspace siblings) into the production image at/deploy/node_modules. As a result,@datum-cloud/datum-uiis absent from the container, and the Remix server bundle can't resolve it at runtime.Fix
Add
@datum-cloud/datum-ui: ^0.8.0todependenciesinui/example/package.json. This ensurespnpm deploy --prodincludes the package in the production image.Test Plan
activity-uipod starts without theCannot find packageerror in staging