fix: better assertion message for existing field value#1513
Conversation
🦋 Changeset detectedLatest commit: 5f80d39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the developer experience by improving the clarity of an assertion message within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves an assertion error message in smart.lib.tengo. The change correctly replaces string concatenation with a format string (%q) in an ll.assert call. This ensures that the field name is properly included in the assertion message when a field is already set, making debugging easier. The change is a good improvement.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
=======================================
Coverage 54.37% 54.38%
=======================================
Files 242 242
Lines 13686 13686
Branches 2820 2820
=======================================
+ Hits 7442 7443 +1
+ Misses 5310 5309 -1
Partials 934 934 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.