Skip to content

fix: strict driver teardown makes tests less flappy #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DenKoren wants to merge 1 commit into from
Closed

fix: strict driver teardown makes tests less flappy #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-places-see.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@milaboratories/pl-drivers": patch
---

Consistent driver cleanup avoids test flaps
4 changes: 3 additions & 1 deletion lib/node/pl-drivers/src/drivers/download_blob/download_blob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ export class DownloadDriver implements BlobDriver, AsyncDisposable {
if (deleted) this.keyToOnDemand.delete(blobKey(blobId));
}

/** Removes all files from a hard drive. */
/** Stops all active downloads, drops all pending (queued) downloads and removes
* all partially downloaded files from storage. */
Comment on lines +638 to +639
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This updated documentation is much clearer, but the implementation of releaseAll doesn't seem to fully match it. The function stops the queue but doesn't appear to abort active downloads or remove partially downloaded files.

To align with this comment and ensure a stricter teardown, releaseAll should probably iterate through this.keyToDownload, and for each task, call this.removeTask(). This would ensure tasks are aborted, triggering the cleanup of any partial files and releasing resources correctly.

async releaseAll() {
this.downloadQueue.stop();

Expand All @@ -646,6 +647,7 @@ export class DownloadDriver implements BlobDriver, AsyncDisposable {
}

async dispose(): Promise<void> {
await this.releaseAll();
await this.rangesCache.dispose();
}

Expand Down
2 changes: 1 addition & 1 deletion tests/workflow-tengo/src/exec/run/hello_go.tpl.tengo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ self.body(func(inputs) {
/* Checks, that default limits are applied based
* on queue block developer choses when bulding the command */
run := exec.builder().
software(sw).
software(sw).
inLightQueue().
arg(inputs.text).
saveStdoutContent().
Expand Down
Loading