Skip to content

[WIP] MILAB-5376: update filter labels#1475

Open
AStaroverov wants to merge 1 commit intomainfrom
feat/filters-renaming
Open

[WIP] MILAB-5376: update filter labels#1475
AStaroverov wants to merge 1 commit intomainfrom
feat/filters-renaming

Conversation

@AStaroverov
Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: 13c23e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@notion-workspace
Copy link
Copy Markdown

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface by updating several filter labels within the application. The changes aim to make the filter options more intuitive and user-friendly, enhancing the overall experience when applying data filters.

Highlights

  • Filter Label Updates: The 'equal' filter label has been updated from 'Col = X (Equal)' to 'Exactly (=)' for improved clarity.
  • Filter Label Updates: The 'notEqual' filter label has been updated from 'Col ≠ X (Not Equal)' to 'Not Equal To (≠)'.
  • Filter Label Updates: The 'lessThan' filter label has been updated from 'Col < X (Less Than)' to 'Below (<)'.
  • Filter Label Updates: The 'greaterThan' filter label has been updated from 'Col > X (Greater Than)' to 'Above (>)'.
  • Filter Label Updates: The 'lessThanOrEqual' filter label has been updated from 'Col ≤ X (Less Than or Equal)' to 'At Most (≤)'.
  • Filter Label Updates: The 'greaterThanOrEqual' filter label has been updated from 'Col ≥ X (Greater Than or Equal)' to 'At Least (≥)'.
  • Filter Label Updates: The 'isNA' filter label has been updated from 'Is NA' to 'Is Empty (NA)'.
  • Filter Label Updates: The 'isNotNA' filter label has been updated from 'Is Not NA' to 'Is Not Empty (≠ NA)'.
Changelog
  • lib/ui/uikit/src/composition/filters/metadata.ts
    • Updated the label for the 'equal' filter to 'Exactly (=)'.
    • Updated the label for the 'notEqual' filter to 'Not Equal To (≠)'.
    • Updated the label for the 'lessThan' filter to 'Below (<)'.
    • Updated the label for the 'greaterThan' filter to 'Above (>)'.
    • Updated the label for the 'lessThanOrEqual' filter to 'At Most (≤)'.
    • Updated the label for the 'greaterThanOrEqual' filter to 'At Least (≥)'.
    • Updated the label for the 'isNA' filter to 'Is Empty (NA)'.
    • Updated the label for the 'isNotNA' filter to 'Is Not Empty (≠ NA)'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the UI labels for various filter operations in lib/ui/uikit/src/composition/filters/metadata.ts. The changes replace technical descriptions with more user-friendly phrases, for example changing 'Col = X (Equal)' to 'Exactly (=)'. These changes are self-contained within the UI metadata and do not affect the filtering logic. After a thorough review, I have not identified any issues or areas for improvement.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.37%. Comparing base (69ceb89) to head (13c23e4).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   54.47%   54.37%   -0.11%     
==========================================
  Files         242      242              
  Lines       13481    13471      -10     
  Branches     2759     2759              
==========================================
- Hits         7344     7325      -19     
- Misses       5219     5225       +6     
- Partials      918      921       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AStaroverov AStaroverov changed the title MILAB-5376: update filter labels [WIP] MILAB-5376: update filter labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant