Skip to content

added tests #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikhailmartin merged 1 commit into from
Sep 18, 2025
Merged

added tests #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smarttree/_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def _check__rank_na_mode(rank_na_mode):
if rank_na_mode not in ("include_all", "include_best"):
raise ValueError(
"`rank_na_mode` must be Literal['include_all', 'include_best']."
f" The current value of `na_mode` is {rank_na_mode!r}."
f" The current value of `rank_na_mode` is {rank_na_mode!r}."
)


Expand Down
52 changes: 51 additions & 1 deletion tests/decision_tree/base/test__check_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from smarttree._types import (
CatNaModeType,
ClassificationCriterionType,
CommonNaModeType,
NaModeType,
NumNaModeType,
)
Expand Down Expand Up @@ -559,6 +560,31 @@ def test__check_params__hierarchy(hierarchy, expected_context):
SmartDecisionTreeClassifier(hierarchy=hierarchy)


@pytest.mark.parametrize(
("na_mode", "expected_context"),
[
("include_all", does_not_raise()),
("include_best", does_not_raise()),
(
"smth",
pytest.raises(
ValueError,
match=re.escape(
"`na_mode` must be Literal['include_all', 'include_best']."
" The current value of `na_mode` is 'smth'."
),
),
),
],
ids=["include_all", "include_best", "invalid"],
)
def test__check_params__na_mode(na_mode, expected_context):
with expected_context:
na_mode: CommonNaModeType
SmartDecisionTreeClassifier(na_mode=na_mode)



@pytest.mark.parametrize(
("num_na_mode", "expected_context"),
[
Expand Down Expand Up @@ -632,6 +658,30 @@ def test__check_param__cat_na_filler(cat_na_filler, expected_context):
SmartDecisionTreeClassifier(cat_na_filler=cat_na_filler)


@pytest.mark.parametrize(
("rank_na_mode", "expected_context"),
[
("include_all", does_not_raise()),
("include_best", does_not_raise()),
(
"smth",
pytest.raises(
ValueError,
match=re.escape(
"`rank_na_mode` must be Literal['include_all', 'include_best']."
" The current value of `rank_na_mode` is 'smth'."
),
),
),
],
ids=["include_all", "include_best", "invalid"],
)
def test__check_params__rank_na_mode(rank_na_mode, expected_context):
with expected_context:
rank_na_mode: CommonNaModeType
SmartDecisionTreeClassifier(rank_na_mode=rank_na_mode)


@pytest.mark.parametrize(
("min_samples_split", "min_samples_leaf", "expected_context"),
[
Expand Down Expand Up @@ -700,5 +750,5 @@ def test__check_params__min_samples_split__min_samples_leaf(
)
def test__check_params__feature_na_mode(feature_na_mode, expected_context):
with expected_context:
feature_na_mode: dict[str, NaModeType | None]
feature_na_mode: dict[str, NaModeType]
SmartDecisionTreeClassifier(feature_na_mode=feature_na_mode)
Loading