Skip to content

fix: stabilize functional search assertions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeclark206 merged 1 commit into from
Apr 29, 2026
Merged

fix: stabilize functional search assertions #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pages/SearchResultsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,15 @@ export class SearchResultsPage {
}

async expectResultContainingText(expectedText: string): Promise<void> {
await expect(
this.page.getByText(expectedText, { exact: false }).first()
).toBeVisible({ timeout: 10000 });
}
const matchingResult = this.page
.locator(
'a[href*="/release/"], a[href*="/master/"], a[href*="/artist/"], a[href*="/label/"]'
)
.filter({ hasText: expectedText })
.first();

await expect(matchingResult).toBeVisible({ timeout: 15000 });
}

async openReleaseOrMasterResult(expectedText: string): Promise<void> {
const releaseOrMasterResult = this.page
Expand Down
2 changes: 1 addition & 1 deletion test-data/search-cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"type": "label",
"query": "Blue Note",
"query": "Blue Note Records",
"expectedText": "Blue Note"
}
]
Loading