onClick action for selectable items#493
Open
GabrielCW wants to merge 4 commits intomike-north:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #492 for the original issue.
Basically, this adds the possibility of passing a click action to selectable items, an action which - contrarily to the default
clickaction - only fires once.It must be called
onClick(overrindingclickjust breaks the components, understandably).There's not much to the implementation here, except for this strange variable
clickActionWasSent. It is required because theclickevent fires twice, and ideally the action passed to the input should only be called once (that's what users will expect).I couldn't write unit tests for this. I'm not unwilling, but I don't really know where to start. I'm not used to writing tests (shame on me), but I'll totally do it if someone gives me a few pointers on how to do it.
Outside of that, the test suite is green.