test: validate skills map entries and add contributing guide#76
Open
tonyblu331 wants to merge 6 commits into
Open
test: validate skills map entries and add contributing guide#76tonyblu331 wants to merge 6 commits into
tonyblu331 wants to merge 6 commits into
Conversation
|
@tonyblu331 is attempting to deploy a commit to the midudev pro Team on Vercel. A member of the Team first needs to authorize it. |
42b8a37 to
8be6a64
Compare
8 tasks
Add structural validation test for SKILLS_MAP and COMBO_SKILLS_MAP with 12 tests verifying entry shape, required fields, detect signals, skill refs, and combo references. Error messages are actionable with format hints. Rewrite CONTRIBUTING.md with AutoSkills-specific guidance: how to add a technology, combo, or fix detection. Includes detection signal priority, skill ref format, common mistakes, and separate checklists. Closes midudev#62. Implements the pragmatic path: validate the catalog contract and document the contribution workflow without splitting the architecture.
be05489 to
cc2e9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
packages/autoskills/tests/skills-map.validation.test.mjs— 12 structural validation tests across 3 suitesCONTRIBUTING.md— AutoSkills-specific contribution guideValidation test — what it checks
SKILLS_MAP:id,name,detect,skills)detecthas at least one signal (packages,configFiles,gems,packagePatterns, orconfigFileContent)RegExpforpackagePatterns, strings for the rest)configFileContentblocks havepatternsand eitherfilesorscanGradleLayout: trueowner/repo/skill-nameorhttps://...COMBO_SKILLS_MAP:requireshas ≥ 2 ids, all of which exist inSKILLS_MAPrequiresError feedback contract (8 additional tests): validates that error messages are actionable — they tell the contributor exactly what to fix and include format hints or examples.
Why This Change
Closes #62.
Discussion in #62 concluded that the registry split proposal was premature at the current scale (~1,300 lines of declarative data). The pragmatic path: add a schema validation test and a clear contribution guide without changing the architecture or raising the bar for contributors.
This PR delivers exactly that:
Testing Done
Type of Change
test:Testsdocs:DocumentationSecurity & Quality Checklist
node:test,node:assert/strict)Documentation
CONTRIBUTING.mdadded with full workflow + AutoSkills-specific guidance