fix(events): eager-deploy EndDate must be end-of-rotation-day, not midnight

[renemadsen]

Summary

Companion fix to PR #813 (eager-deploy of future events). When EnsureDeployedAsync ran on a TODAY rotation, the SDK case was never created because of a stale mainElement.EndDate value:

• mainElement.EndDate = rotationDate (parsed as midnight UTC)
• Downstream guard: if (mainElement.EndDate > DateTime.UtcNow) skips CaseCreate
• Today's deploy fires after 00:00 UTC → guard fails → _sdkCore.CaseCreate is silently skipped
• Compliance row written anyway with MicrotingSdkCaseId=0 (from the unmodified planningCaseSite.MicrotingSdkCaseId)
• Result: UploadPhoto / CompleteEvent for these rotations fail with FailedPrecondition

Fix: use rotationDate.AddDays(1).AddTicks(-1) (end-of-rotation-day UTC) so the guard passes any time the deploy fires within the rotation day.

Why this slipped past PR #814's tests

PR #814's 5 tests covered: empty window, past rotation, IsFromCompliance filter, idempotence guard, cancellation. None drove a today rotation through to the EndDate guard, because doing so cleanly requires the full Planning+AreaRulePlanning+Area+Property+eForm graph that we deferred (the SKIPPED tests #5/#6/#8 in the test file).

Regression test included

EnsureDeployedAsync_TodayRotation_AdmittedByCandidateFilter — pins that today's rotation is admitted by the candidate filter at line 131 (rotationDate >= todayUtc). A future refactor that accidentally narrowed this to > todayUtc would silently exclude today's rotations again. The test comment is honest about what it does and doesn't cover (doesn't directly exercise the EndDate guard — that needs the full graph).

Verification

• Pre-push dual-subagent gate (code-reviewer + code-simplifier).
• Code-reviewer initially flagged the test name oversold its scope; consolidation commit 7031c567 renamed to be honest about what's pinned vs deferred.
• dotnet build clean (0 errors).

Also worth knowing: two existing Compliance rows in the local DB (420_eform-backend-configuration-plugin.Compliances IDs 10219 + 10222) have MicrotingSdkCaseId=0 from before the fix. They need to be soft-deleted (WorkflowState='Removed') so the next eager deploy creates them properly. That's a runtime data-cleanup task, not part of this code change.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Companion fix to PR #813. The eager-deploy path set mainElement.EndDate = rotationDate (midnight UTC), so the downstream guard if (mainElement.EndDate > DateTime.UtcNow) skipped CaseCreate for any same-day deploy fired after 00:00 UTC, leaving Compliance rows with MicrotingSdkCaseId=0. The fix shifts EndDate to end-of-rotation-day UTC so the guard passes throughout the rotation day, and adds a regression test pinning that today's rotations are admitted by the candidate filter.

Changes:

• Set mainElement.EndDate = rotationDate.AddDays(1).AddTicks(-1) and update surrounding comments to document the rationale.
• Add integration test EnsureDeployedAsync_TodayRotation_AdmittedByCandidateFilter that verifies a today-dated rotation reaches the planning-lookup step.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Services/EventDeployService/EventDeployService.cs	Use end-of-rotation-day UTC for mainElement.EndDate so the same-day deploy guard passes.
eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn.Integration.Test/EventDeployServiceTest.cs	Adds regression test pinning that the candidate filter admits today's rotation.