Skip to content

promote: Phase 2 (tavle→board rename) from master to stable #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 2 commits into from
May 12, 2026
Merged

promote: Phase 2 (tavle→board rename) from master to stable #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01694e2
feat(events): Phase 2 — rename gRPC tavle types to board
renemadsen May 12, 2026
b84b576
Merge pull request #803 from microting/feat/tavle-to-board-rename
renemadsen May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Protos/events.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
syntax = "proto3";

// Mid-migration: opgave -> event per
// Mid-migration: opgave -> event, tavle -> board per
// docs/superpowers/specs/2026-05-11-opgave-to-event-migration.md.
//
// This phase renames the "opgave" noun only: service, package, message
// types (Opgave/OpgaveChange/CompleteOpgave* -> Event/...), and RPC
// method names. The Ejendom/Tavle/rode nouns and all field names (e.g.
// `repeated Event opgaver = 1;`) deliberately stay as-is — keeping the
// wire identifiers preserves the generated C# accessors
// (`response.Opgaver.Add(...)`, `new CompleteEventResponse { Opgave =
// ... }`) and limits this PR to the smallest viable diff. Follow-up
// phases handle those renames.
// Wire field names (`opgaver`, `tavler`, `tavle_id`, `tavle_ids`,
// `ejendom_id`) stay as-is so generated accessors don't churn; only
// message types and RPC method names move. Ejendom and rode renames
// land in follow-up phases.
Comment on lines +6 to +8

package backend_configuration;

Expand All @@ -21,7 +16,7 @@ import "documents.proto";

service Events {
rpc ListEjendomme(ListEjendommeRequest) returns (ListEjendommeResponse);
rpc ListTavler(ListTavlerRequest) returns (ListTavlerResponse);
rpc ListBoards(ListBoardsRequest) returns (ListBoardsResponse);
rpc ListEvents(ListOpgaverRequest) returns (ListOpgaverResponse);
rpc ListTaskTracker(ListTaskTrackerRequest) returns (ListTaskTrackerResponse);
rpc StreamEventChanges(StreamOpgaveChangesRequest) returns (stream EventChange);
Expand Down Expand Up @@ -130,8 +125,8 @@ message SetFieldValueResponse { Event opgave = 1; }
message ListEjendommeRequest {}
message ListEjendommeResponse { repeated Ejendom ejendomme = 1; }

message ListTavlerRequest { string ejendom_id = 1; }
message ListTavlerResponse { repeated Tavle tavler = 1; }
message ListBoardsRequest { string ejendom_id = 1; }
message ListBoardsResponse { repeated Board tavler = 1; }

message ListOpgaverRequest {
string ejendom_id = 1;
Expand Down Expand Up @@ -168,7 +163,7 @@ message Ejendom {
string name = 2;
}

message Tavle {
message Board {
string id = 1;
string ejendom_id = 2;
string name = 3;
Expand Down
10 changes: 5 additions & 5 deletions ...ackendConfiguration.Pn/BackendConfiguration.Pn/Services/GrpcServices/EventsGrpcService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace BackendConfiguration.Pn.Services.GrpcServices;

/// <summary>
/// gRPC adapter for the mobile "Opgaver" feature.
/// Read-only RPCs (ListEjendomme / ListTavler / ListOpgaver) reuse the existing
/// Read-only RPCs (ListEjendomme / ListBoards / ListOpgaver) reuse the existing
/// Properties + Calendar service paths and reshape the result into the
/// microting.opgaver wire contract. CompleteOpgave performs the SDK-case
Comment on lines 33 to 37
/// completion inline (mirroring CompliancesGrpcService.UpdateComplianceCase,
Expand Down Expand Up @@ -145,8 +145,8 @@ public override async Task<ListEjendommeResponse> ListEjendomme(
return response;
}

public override async Task<ListTavlerResponse> ListTavler(
ListTavlerRequest request,
public override async Task<ListBoardsResponse> ListBoards(
ListBoardsRequest request,
ServerCallContext context)
{
var propertyId = ParsePropertyId(request.EjendomId);
Expand All @@ -160,7 +160,7 @@ public override async Task<ListTavlerResponse> ListTavler(

var result = await calendarService.GetBoards(propertyId);

var response = new ListTavlerResponse();
var response = new ListBoardsResponse();

if (!result.Success || result.Model == null)
{
Expand All @@ -169,7 +169,7 @@ public override async Task<ListTavlerResponse> ListTavler(

foreach (var board in result.Model)
{
response.Tavler.Add(new Tavle
response.Tavler.Add(new Board
{
Id = board.Id.ToString(CultureInfo.InvariantCulture),
EjendomId = board.PropertyId.ToString(CultureInfo.InvariantCulture),
Expand Down
Loading