Open
Conversation
permissions from JSON files
andrueastman
reviewed
Dec 4, 2023
| await ParseFromGEPermissions(doc, commandOptions.SourcePermissionsFile, commandOptions.SourceDescriptionsFile); | ||
| var importer = new PermissionsImporter(); | ||
|
|
||
| var doc = importer.Import(commandOptions.SourcePermissionsFile, commandOptions.SourceDescriptionsFile).Result; |
Contributor
There was a problem hiding this comment.
Suggested change
| var doc = importer.Import(commandOptions.SourcePermissionsFile, commandOptions.SourceDescriptionsFile).Result; | |
| var doc = await importer.Import(commandOptions.SourcePermissionsFile, commandOptions.SourceDescriptionsFile); |
| @@ -0,0 +1,170 @@ | |||
| using Kibali; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| using Kibali; |
| JsonElement rootObject; | ||
| JsonElement permissionsObject; | ||
|
|
||
| using (var client = new HttpClient()) |
Contributor
There was a problem hiding this comment.
Maybe we should make this instance a static member?
https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines#recommended-use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enhance reusability (especially in the devX API), it would be easier to have the functionality move up to the DLL so that we can use the Import function as to generate the document first before passing it to the AuthZChecker without having to reuse the code to support this.
Microsoft Reviewers: Open in CodeFlow