Skip to content

Remove 30-day parameter cap for inactive sign-in user cmdlets (v1.0 + beta) #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove 30-day parameter cap for inactive sign-in user cmdlets (v1.0 + beta) #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
346ea7a
Initial plan
Copilot May 14, 2026
3148256
Fix inactive sign-in cmdlet day limit above 30
Copilot May 14, 2026
b8d7d51
Refine day range validation to use int max constant
Copilot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function Get-EntraInactiveSignInUser {
# User Last Sign In Activity is before Days ago
[Parameter(ValueFromPipeline = $true, Position = 1)]
[Alias("BeforeDaysAgo")]
[ValidateRange(0,30)]
[ValidateRange(0, [int]::MaxValue)]
[int] $LastSignInBeforeDaysAgo = 30,
# Return results for All, Member, or Guest userTypes
[ValidateSet("All", "Member", "Guest")]
Expand Down Expand Up @@ -109,4 +109,3 @@ function Get-EntraInactiveSignInUser {
}
}
}

4 changes: 1 addition & 3 deletions module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function Get-EntraBetaInactiveSignInUser {
# User Last Sign In Activity is before Days ago
[Parameter(ValueFromPipeline = $true, Position = 1)]
[Alias("BeforeDaysAgo")]
[ValidateRange(0,30)]
[ValidateRange(0, [int]::MaxValue)]
[int] $LastSignInBeforeDaysAgo = 30,
# Return results for All, Member, or Guest userTypes
[ValidateSet("All", "Member", "Guest")]
Expand Down Expand Up @@ -107,5 +107,3 @@ function Get-EntraBetaInactiveSignInUser {
}
}
}


7 changes: 7 additions & 0 deletions test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ Describe 'Get-EntraInactiveSignInUser' {
$result[2].UserID | Should -Be "user3"
}

It "Should allow LastSignInBeforeDaysAgo above 30" {
$result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All"

$result | Should -Not -BeNullOrEmpty
Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Users -Times 1
}

It "Should return only inactive Member users" {
$result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member"

Expand Down
7 changes: 7 additions & 0 deletions test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ Describe 'Get-EntraBetaInactiveSignInUser' {
$result[2].UserID | Should -Be "user3"
}

It "Should allow LastSignInBeforeDaysAgo above 30" {
$result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All"

$result | Should -Not -BeNullOrEmpty
Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Beta.Users -Times 1
}

It "Should return only inactive Member users" {
$result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member"

Expand Down